Bug 263417

Comment 1 Yasuhiro Kimura 2022-05-04 08:00:39 UTC

Maintainer timeout. Take.

Comment 2 Rodrigo Osorio 2022-05-04 08:03:58 UTC

@yasuhiro: It will be nice if you can contact me directly before taking my PR

Comment 3 commit-hook 2022-05-04 08:17:19 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=21f77dd22253ffbe6a16b0367fda3f17c94848ac

commit 21f77dd22253ffbe6a16b0367fda3f17c94848ac
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2022-04-19 11:27:39 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2022-05-04 08:05:33 +0000

    net/rsync: Update to 3.2.4

    * Pet portclippy
    * Tidy up Makefile with portfmt

    ChangeLog:      https://download.samba.org/pub/rsync/NEWS#3.2.4
    PR:             263417
    Approved by:    maintainer timeout

 net/rsync/Makefile                | 69 +++++++++++++++++++--------------------
 net/rsync/distinfo                | 10 +++---
 net/rsync/files/patch-io.c (gone) | 27 ---------------
 3 files changed, 39 insertions(+), 67 deletions(-)

Comment 4 Yasuhiro Kimura 2022-05-04 08:23:34 UTC

(In reply to Rodrigo Osorio from comment #2)

I got it. I'll do it next time I submitted PR for you ports.

Created attachment 233723 [details]
patch to post-patch to fix man pages

(In reply to Yasuhiro Kimura from comment #0)

Thanks for doing this. There is a problem with the previous port that still exists. The post-patch changes to the '/etc/' path make some incorrect assumptions:

post-patch:
@${REINPLACE_CMD} -e 's:/etc/:${ETCDIR}/:g' \
                ${WRKSRC}/rsync.1 ${WRKSRC}/rsyncd.conf.5

In the man pages for rsync(1) and rsyncd.conf(5), files such as /etc/passwd and /etc/services are renamed to /usr/local/etc/rsync/passwd and /usr/local/etc/rsync/services

In addition, the example path for "letsencrypt" is modified to /usr/local/etc/rsync/

Further more, if the user happens to have textproc/py-cmarkgfm installed along with python, then the modified rsync.1 , rsyncd.conf.1 and rsync-ssl.1 are not even used - they are automatically rebuilt via the script "mdconvert" from the associated *.md files, so the conversions should be done on these too.

I originally emailed the fix to Rodrigo, but assume he didn't receive it.

Attached here is the rebased patch.

cheers

I've just noticed a dependency on python has been added to the Makefile.

This is NOT required. I just removed this on my smaller servers and everything works fine.

Please can this be removed? Like many, I have rsync on just about everything, and some of those machines are too small to house an unnecessary python dependency!

Comment 7 Rodrigo Osorio 2022-05-05 08:09:27 UTC

(In reply to Jamie Landeg-Jones from comment #6)

@Jamie, I receive your email but has no time to do the proper tests.
Our work as port maintainer in to guarantee that ports works smoothly
for anyone, and don't break. This implies to do proper tests before
committing changes. rsync is a sensitive project, and many peoples relay
on it for their day to day job.

Also you must asume the project is run by volunteers, with a dayjob
to pay the bills, you can't expect a D+1 answer to all your requests.

By the way, if you decide to do the job, you must do it properly,
and accept the consequences when you break something.

Comment 8 Rodrigo Osorio 2022-05-05 08:13:16 UTC

Comment on attachment 233723 [details]
patch to post-patch to fix man pages

This is a separate issue, I will open a separate PR for it

(In reply to Rodrigo Osorio from comment #7)

Thanks for doing this, and the response.

I know my email was only 4 days old, and that was fine. I only mentioned it now because Yasuhiro brought up the 3 week maintainer timeout, so I assumed you were away or simply busy.

I know the situation, I've been using FreeBSD since 2.2.6 - I have a few (albeit) small patches in the src tree, and I maintain a few ports myself (that number is going down, and some I have resorted to "maintaining" privately simply due to the lack of response when submitting bugs).

For instance, a recent maintainer updater took a month to get actioned (and users were bugging me in the meantime)

I am currently being spammed by pkg-fallout over another port I maintain that no longer compiles on 14. - A maintainer update I submitted for that is still sitting there.

I currently have (what I think) is an enhancement (with patch) PR -- it's been sitting ignored for months. Maybe it's crap, but who knows?

I also have another (small) bug fix sitting there ignored.

Out of desperation, I've now setup my own infrastructure so any of my patches to src/ports are automatically rolled out to all my machines, and integrated. So apart from occasional patch rebasing, getting fixes integrated upstream doesn't help me.

I have locally, bug fixes for about 4 other things. I've not submitted them, because what's the point?

I emailed you directly because no-one responds to PR's, and my reply to Yasuhiro here was certainly not a dig personally at you.

I've offered to help many times in the past, but have either been rebuffed or ignored. Maybe I need to hang out on IRC? Or maybe being a FreeBSD advocate and hacker for over 25 years isn't considered long enough?

Again, this is not an attack at you, but overall frustration. How many people have given up submitting fixes or other patches, or even given up with FreeBSD altogether, simply because no-one listens?

Cheers, Jamie

Comment 10 Rodrigo Osorio 2022-05-05 11:55:57 UTC

To close the thread, because this is not the place
to have an open debate.

Please Jamie, don't take my last words too personally
I understand what you say and your goals are laudable,
but pushing a patch who has nothing to do with this PR
is not part of good practices.

Regarding rsync update, as you can see the updated
was committed over my will, with some unexpected flaws,
so pursuing this way is clearly not something I can approve.