Bug 263487

Summary: dns/bind918: nullfs mount is missing
Product: Ports & Packages Reporter: Tatsuki Makino <tatsuki_makino>
Component: Individual Port(s)Assignee: Mathieu Arnold <mat>
Status: Closed FIXED    
Severity: Affects Only Me CC: freebsd
Priority: --- Flags: bugzilla: maintainer-feedback? (mat)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
chroot path fix none

Description Tatsuki Makino 2022-04-23 07:35:00 UTC 
When using BIND chrooted, some directories will be nullfs mounted, but some will be missing.
The directory names seem to have changed between 9.16.x and 9.18.x.
The following line of files/named.in may need to be rewritten.

- null_mount_or_copy %%PREFIX%%/lib/named
+ null_mount_or_copy %%PREFIX%%/lib/bind

bind9-devel will probably need to be modified as well.
Comment 1 Leo Vandewoestijne 2022-05-24 11:25:32 UTC 
That same file will also need a
- null_umount %%PREFIX%%/lib/named
+ null_umount %%PREFIX%%/lib/bind
Comment 2 Leo Vandewoestijne 2022-05-31 07:37:11 UTC 
Created attachment 234341 [details]
chroot path fix

By these the patch to make the above two mutations.
Comment 3 Tatsuki Makino 2022-06-02 05:12:14 UTC 
This value is a macro that is defined as NAMED_PLUGINDIR in preprocessor for both 9.16 and 9.18.
In 9.16, ${plugindir} defined in bind-9.16.29/make/rules.in is assigned to it.
In 9.18, it has been changed to use ${pkglibdir} defined by autotools(? I don't know details :) ).

So, it may be necessary to use the equivalent of $(libdir)/@PACKAGE@ to allow more accurate values to be entered.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-15 14:31:20 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fa2609e30ffecf7ae3818b84bb9c017ccecc5892

commit fa2609e30ffecf7ae3818b84bb9c017ccecc5892
Author:     Tatsuki Makino <tatsuki_makino@hotmail.com>
AuthorDate: 2022-07-15 14:26:44 +0000
Commit:     Mathieu Arnold <mat@FreeBSD.org>
CommitDate: 2022-07-15 14:30:17 +0000

    dns/bind918: fix nullfs mount when chrooted

    PR:             263487

 dns/bind918/Makefile       | 2 +-
 dns/bind918/files/named.in | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-07-22 13:54:28 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=34f95b934d089c23e1ae98ea363ee6eb42f862ad

commit 34f95b934d089c23e1ae98ea363ee6eb42f862ad
Author:     Tatsuki Makino <tatsuki_makino@hotmail.com>
AuthorDate: 2022-07-15 14:26:44 +0000
Commit:     Mathieu Arnold <mat@FreeBSD.org>
CommitDate: 2022-07-22 13:52:18 +0000

    dns/bind918: fix nullfs mount when chrooted

    PR:             263487
    (cherry picked from commit fa2609e30ffecf7ae3818b84bb9c017ccecc5892)

 dns/bind918/Makefile       | 2 +-
 dns/bind918/files/named.in | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)