Bug 263562

Summary: editors/rehex: update to 0.5.0
Product: Ports & Packages Reporter: Robert Clausecker <fuz>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/solemnwarning/rehex/releases/tag/0.5.0
Attachments:
Description Flags
editors/rehex: update to 0.5.0 fuz: maintainer-approval+

Description Robert Clausecker freebsd_committer freebsd_triage 2022-04-25 12:07:37 UTC 
Created attachment 233477 [details]
editors/rehex: update to 0.5.0

- pacify portlint, Poudriere
 - strip installed binaries
 - add missing dependencies
 - take over maintainership of this unmaintained port

Changelog:	https://github.com/solemnwarning/rehex/releases/tag/0.5.0

Tested with Poudriere on i386 amd64 armv7 arm64 FreeBSD 12 and 13.
Portlint and portclippy are both happy.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-04-28 06:01:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=930715f767ccfb6375ee7c56f7ba3134541593de

commit 930715f767ccfb6375ee7c56f7ba3134541593de
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-04-27 07:20:11 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-04-28 05:58:56 +0000

    editors/rehex: update to 0.5.0

    ChangeLog: https://github.com/solemnwarning/rehex/releases/tag/0.5.0

    Submitter requests maintainership. Already maintainer of several ports.

    PR:     263562
    Reported by:    fuz@fuz.su (maintainer)

 editors/rehex/Makefile                             | 18 ++++++++----
 editors/rehex/distinfo                             |  6 ++--
 editors/rehex/files/patch-Makefile                 | 32 ++++++++++++----------
 .../patch-plugins_binary-template_Makefile (new)   | 11 ++++++++
 editors/rehex/pkg-plist                            | 13 +++++++++
 5 files changed, 58 insertions(+), 22 deletions(-)
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-04-28 06:02:18 UTC 
Committed,

Thanks!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-04-28 13:24:58 UTC 
Hi Robert,

It's been brought to my attention the change in ${STRIP} and using install instead of ${BSD_INSTALL_PROGRAM} that should strip binaries automatically.
And similarly with ${BSD_INSTALL_PROGRAM}

Why the switch from those variables provided by the framework?
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2022-04-28 13:53:37 UTC 
(In reply to Fernando Apesteguía from comment #3)

Hi Fernando,

I've tried to remove BSD-specific macros from the patch so I can contribute it up stream with the eventual goal of being able to completely remove the patch.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-04-28 14:44:54 UTC 
(In reply to Robert Clausecker from comment #4)
It makes sense to me.

Thanks for the clarification.