Summary: | random_fortuna: standalone module build broken in stable/12 | ||
---|---|---|---|
Product: | Base System | Reporter: | Eugene Grosbein <eugen> |
Component: | kern | Assignee: | Eugene Grosbein <eugen> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | CC: | emaste, jhs, obrien |
Priority: | --- | ||
Version: | 12.3-STABLE | ||
Hardware: | Any | ||
OS: | Any |
Description
Eugene Grosbein
![]() ![]() First line should be: cd /home/src/sys/modules/random_fortuna && make It seems the following trivial patch should be enough to fix this. --- sys/modules/random_fortuna/Makefile.orig 2022-05-03 16:11:02.665565000 +0700 +++ sys/modules/random_fortuna/Makefile 2022-05-03 16:10:55.497517000 +0700 @@ -6,6 +6,6 @@ SRCS = randomdev.c hash.c fortuna.c SRCS += opt_param.h bus_if.h device_if.h SRCS += opt_ddb.h -CFLAGS += -DRANDOM_LOADABLE +CFLAGS += -DDEV_RANDOM -DRANDOM_LOADABLE .include <bsd.kmod.mk> --- sys/modules/random_other/Makefile.orig 2022-05-03 16:09:34.601209000 +0700 +++ sys/modules/random_other/Makefile 2022-05-03 16:08:59.489104000 +0700 @@ -6,6 +6,6 @@ SRCS = randomdev.c hash.c other_algorithm.c SRCS += opt_param.h bus_if.h device_if.h SRCS += opt_ddb.h -CFLAGS += -DRANDOM_LOADABLE +CFLAGS += -DDEV_RANDOM -DRANDOM_LOADABLE .include <bsd.kmod.mk> I jhs@ confirm the logic of patch marked Comment2 2022-05-03 09:12:25 UTC However the patch has to be applied manually as tabs seem to have been converted to spaces before th patch was generated. Thanks Aha, not an issue on stable/13 and later, after sys: Remove DEV_RANDOM device option Remove 'device random' from kernel configurations that reference it (most). Replace perhaps mistaken 'nodevice random' in two MIPS configs with 'options RANDOM_LOADABLE' instead. Document removal in UPDATING; update NOTES and random.4. Reviewed by: delphij, markm (previous version) Approved by: secteam(delphij) Differential Revision: https://reviews.freebsd.org/D19918 (In reply to Eugene Grosbein from comment #2) Patch LGTM, please commit to stable/12. A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=487fcaf8e9b7b7faabdbcbf0293ed09d1de95889 commit 487fcaf8e9b7b7faabdbcbf0293ed09d1de95889 Author: Eugene Grosbein <eugen@FreeBSD.org> AuthorDate: 2022-05-03 20:23:22 +0000 Commit: Eugene Grosbein <eugen@FreeBSD.org> CommitDate: 2022-05-03 20:28:49 +0000 random_fortuna, random_other: unbreak standalone module build This is direct commit to stable/12 as newer branches do not have the problem. PR: 263750 Reviewed by: emaste Tested by: Julian H. Stacey <jhs at berklix.com> sys/modules/random_fortuna/Makefile | 2 +- sys/modules/random_other/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) |