Bug 263795
| Summary: | security/p5-openxpki*: Update to 3.18.2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sergei Vyshenski <svysh.fbsd> | ||||||
| Component: | Individual Port(s) | Assignee: | Nuno Teixeira <eduardo> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | eduardo, svysh.fbsd | ||||||
| Priority: | --- | Flags: | svysh.fbsd:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://github.com/openxpki/openxpki/compare/v3.18.0...v3.18.2 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sergei Vyshenski
2022-05-05 13:31:26 UTC
Hello, I'm working in this update and I noticed a lot of: --- REINPLACE_CMD ran, but did not modify file contents: /lots of files/ --- Can you checkup your poudriere log to see if it is possible to remove unused reinplace cmds? A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6442f22da80754bfcb7ae19f36b0d2ed7d3870bf commit 6442f22da80754bfcb7ae19f36b0d2ed7d3870bf Author: Sergei Vyshenski <svysh.fbsd@gmail.com> AuthorDate: 2022-05-17 10:13:41 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-05-17 10:15:54 +0000 security/p5-openxpki*: Update to 3.18.2 Changelog: https://github.com/openxpki/openxpki/compare/v3.18.0...v3.18.2 PR: 263795 security/p5-openxpki-i18n/Makefile | 2 +- security/p5-openxpki-i18n/distinfo | 6 +++--- security/p5-openxpki/Makefile | 2 +- security/p5-openxpki/distinfo | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) Email me if you solve reinplace warning with a new diff. Commited, thanks! Nuno, Thank you for your contribution. These dummy REINPLACE_CMD calls do a clever job. They search and process linux-like constructs in locations, which are unknown in advance. Upstream people tend to change directories structure and to introduce new linux-like stuff, which is hard to detect during tests. The present version of REINPLACE_CMD calls is very robust regarding unexpected changes of the source code. Let me know if you still think that many warnings from REINPLACE_CMD is an unacceptable practice. Regards, Sergei Created attachment 234153 [details]
"git diff" to update the port
Nuno,
Please find a patch which eliminates annoying warnings from dummy REINPLACE_CMD calls. As you asked for.
Regards, Sergei
Hello Sergei! Nice work! Poudriere logs are very clean now. Any sugestion to this portrevision info commit? Something like: "adjust REINPLACE_CMD for better hits" or "eliminates annoying warnings from dummy REINPLACE_CMD calls" It is sure up to you. Thank you. and about POERTREVISION bumped up? I'm thinking not bump PORTREVISION to 1 since there is no changes to user. Agreed, if you asking me. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d8b81c2c885b061e33e5975ee5e2eef71a7ddfce commit d8b81c2c885b061e33e5975ee5e2eef71a7ddfce Author: Sergei Vyshenski <svysh.fbsd@gmail.com> AuthorDate: 2022-05-23 19:42:53 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-05-23 19:49:19 +0000 security/p5-openxpki: adjust REINPLACE_CMD warnings - adjust REINPLACE_CMD for better hits and eliminate lots of warnings about files that it don't apply. - not bumping PORTREVISION since there are no funcionality changes. PR: 263795 security/p5-openxpki/Makefile | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) Commited thanks! |
