Summary: | [NEW PORT] devel/fungw: function gateway | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Robert Clausecker <fuz> | ||||||
Component: | Individual Port(s) | Assignee: | Li-Wen Hsu <lwhsu> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | lwhsu | ||||||
Priority: | --- | Keywords: | feature | ||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | http://repo.hu/projects/fungw/ | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 263849, 264289 | ||||||||
Attachments: |
|
Description
Robert Clausecker
2022-05-06 15:21:12 UTC
Forgot to mention: Tested successfully on armv7 arm64 i386 amd64 FreeBSD 13. Portlint and portclippy like the port. Created attachment 233773 [details]
[NEW PORT] devel/fungw: function gateway
Replaced patch with updated patch that address an issue I didn't notice in initial testing (port has a second header file + library it requires, but doesn't install for some reason).
Some minor suggestions: - How about a more descriptive comment? How about something like "C Function gateway for different programming languages" ? - Since we have `PYTHON3_USES=python`, how about just name the option PYTHON3 as PYTHON? As now python3 is the default anyway - What's python(2) in the comment of line 18? (In reply to Li-Wen Hsu from comment #3) > How about a more descriptive comment? How about something like "C Function gateway for different programming languages" ? You can change it to that when you commit if you like, but I think it might be too long for the COMMENT field. > Since we have `PYTHON3_USES=python`, how about just name the option PYTHON3 as PYTHON? As now python3 is the default anyway PYTHON and PYTHON3 are pre-defined options from bsd.options.desc.mk. The port has both Python 2 and Python 3 binding support, but due to the deprecation of Python 2, I had only implemented the Python 3 binding. That also explains the python(2) comment as the binding is just called “python” but refers to Python 2. So naming the option PYTHON3 makes clear that Python 3 support is meant. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5b1f2cff0ed195b4a215b78c2f58b6ff21c5f4ac commit 5b1f2cff0ed195b4a215b78c2f58b6ff21c5f4ac Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-06-05 15:11:27 +0000 Commit: Li-Wen Hsu <lwhsu@FreeBSD.org> CommitDate: 2022-06-05 15:11:27 +0000 Add devel/fungw: C Function gateway for different programming languages PR: 263819 devel/Makefile | 1 + devel/fungw/Makefile (new) | 47 ++++++++++ devel/fungw/distinfo (new) | 3 + devel/fungw/files/patch-Makefile (new) | 64 +++++++++++++ devel/fungw/files/patch-doc_Makefile.in (new) | 18 ++++ devel/fungw/files/patch-libfungw_Makefile.in (new) | 25 ++++++ .../files/patch-libfungwbind_Makefile.in (new) | 20 +++++ .../files/patch-libfungwbind_Plugin.tmpasm (new) | 25 ++++++ .../fungw/files/patch-regression_Makefile.in (new) | 11 +++ ...atch-scconfig_src_scripts_find__duktape.c (new) | 11 +++ .../patch-scconfig_src_scripts_find__lua.c (new) | 11 +++ ...patch-scconfig_src_scripts_find__python.c (new) | 19 ++++ .../files/patch-src__3rd_genht_Makefile (new) | 38 ++++++++ devel/fungw/pkg-descr (new) | 22 +++++ devel/fungw/pkg-plist (new) | 100 +++++++++++++++++++++ 15 files changed, 415 insertions(+) |