Summary: | www/webkit2-gtk3: Patch for installing gtk-doc/devhelp documentation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Sean Champ <lab+bsd> | ||||||
Component: | Individual Port(s) | Assignee: | freebsd-gnome (Nobody) <gnome> | ||||||
Status: | New --- | ||||||||
Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(gnome) |
||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Sean Champ
2022-05-08 23:54:51 UTC
Created attachment 233815 [details]
patch for adding a docs option to the www/webkit2-gtk3 build
In review of my own patch here lol, I was able to get the patched pkg to build at least once, sufficient to view the documentation in devhelp. I'm not certain if the plist that was in effect then might change across any subsequent builds, even with the same distfiles. I'd seen the following today, building the patched pkg under poudriere with the ostensible docs option enabled: ~~~~ ====> Compressing man pages (compress-man) =========================================================================== =======================<phase: package >============================ ===== env: 'PKG_NOTES=build_timestamp built_by' 'PKG_NOTE_build_timestamp=2022-05-09T13:52:08+0000' 'PKG_NOTE_built_by=poudriere-git-3.3.99.20211130' NO_DEPENDS=yes USER=poudriere UID=65532 G> ===> Building package for webkit2-gtk3-2.34.6_3 pkg-static: Unable to access file /wrkdirs/usr/ports/www/webkit2-gtk3/work/stage/usr/local/share/gtk-doc/html/webkit2gtk-4.0/api-index-2-31.html:No such file or directory *** Error code 1 ~~~~ By now, using ccache in this build config, the build ran only for about a half hour on the build host. Once the poudriere run completes, I'll try to figure out how to handle the docs index files for the pkg-plist, can possibly generate that part of the plist manually Created attachment 233827 [details]
patch for adding docs option with dynamic plist gen
It's possible to generate a dynamic plist for the gtk-doc files. The updated patch, as attached, uses one approach to this, using add-plist-docs
add-plist-docs is supported under bsd.port.mk, mainly for handling PORTDOCS, in a manner similar to PORTEXAMPLES under an EXAMPLES port option. By defininig add-plist-docs in a port, in effect it will override any handling for PORTDOCS. That variable was not previously being used in the port.
The updated patch will use add-plist-docs to update ${TMPPLIST} before the pkg is built. This approach would entail no further modification on the static pkg-plist for the port, and no hacks on the PLIST variable.
The updated patch also removes the earlier CMAKE_INSTALL_DOCDIR parameter from the cmake parameters for the DOCS port option.
Also in the updated patch, installing NEWS from the distfile under the port's DOCSDIR
With the DOCS option enabled, it might be advised to use CC as LD. Possibly something in the docs build may be passing cflags to LD. I've managed this locally with some hacks on toolchain variables, have not tested the build without this configuration. |