Bug 263962
| Summary: | games/taisei: Modernize port and use upstream release archive | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed Not Accepted | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(amdmi3) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Switching from USE_GITHUB is a major pessimization, USE_GITHUB is always preferred over tarballs for: - consistency (contents and layout are stable and predictable; there's no variance in topmost directory name, there are no generated files included, and there are no files omitted from the distribution) - security (no need to trust extra parties which produce the tarballs, and the contents are trivial to verify) - flexibility (trivial to switch to a specific commit or a fork) Other changes are noop and do no bring any good, so rejected, sorry. USE_GITHUB is not preferred, quote from Porters Handbook section 5.4.3 "5.4.3. USE_GITHUB If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file, there is an easy way to set the right DISTNAME and MASTER_SITES automatically." Other changes are related to Porters Handbook guidelines and/or portlint which is also used with Poudriere and have its own section in Porters Handbook, 10.3. Portlint. If you have disagreements with Porters Handbook please submit a PR about it upstream. We all benefit in the end we try to adhere to it as much as possible for consistency. (In reply to Daniel Engberg from comment #2) > quote from Porters Handbook section For the note, there's not a single word about the preference. (In reply to Dmitry Marakasov from comment #3) Hi, "for which there is no officially released file", file here refers to "distribution file" mentioned earlier in the same sentence. Best regards, Daniel (In reply to Daniel Engberg from comment #4) Again, nothing about preference. It is given the context, placement and phrasing in Porters Handbook. The complete section is placed after "5.4.2. MASTER_SITES" so if you read Porters Handbook top down you'll get to that section before "5.4.3. USE_GITHUB". It's also intended as a subsitutue as the phrasing goes "for which there is no officially released file". The officially released file is the distrbution file (archive/tarball) provided by upstream. Best regards, Daniel |
Created attachment 233902 [details] Patch for taisei Adapt Makefile to follow Porters Handbook more closely Switch to upstream release archive as recommended by Porters Handbook (USE_GITHUB section) Pet portlint Tested with default port settings using Poudriere (12.3, amd64)