Bug 264112

Summary: net/onedrive: Update to 2.4.17
Product: Ports & Packages Reporter: Graham Perrin <grahamperrin>
Component: Individual Port(s)Assignee: Koichiro Iwao <meta>
Status: Closed FIXED    
Severity: Affects Some People CC: hiroo.ono+freebsd, meta
Priority: --- Flags: meta: maintainer-feedback+
meta: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/abraunegg/onedrive/blob/v2.4.17/CHANGELOG.md
See Also: https://github.com/abraunegg/onedrive/pull/1862
Attachments:
Description Flags
update patch to 2.4.17 hiroo.ono+freebsd: maintainer-approval+

Description Graham Perrin freebsd_committer freebsd_triage 2022-05-21 02:23:35 UTC 
% pkg info -x onedrive
onedrive-2.4.16
% onedrive --synchronize

WARNING: Your onedrive client version is obsolete and unsupported. Please upgrade your client version.

Configuring Global Azure AD Endpoints
Initializing the Synchronization Engine ...
Syncing changes from OneDrive ...
Uploading differences of ~/OneDrive
Uploading new items of ~/OneDrive
%
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-05-21 03:10:31 UTC 
@Graham Thank you for the report.

This appears to be intentional upstream behaviour, added in in 2.4.16 [1] with a version check. 

I would ask upstream to improve the messaging, perhaps mentioning the latest version, so it looks less like a DANGEROUS SITUATION and more like a plain version check and convenience notice, less likely to result in bug reports :)

I'll update this issue to request a version update.

[1] https://github.com/abraunegg/onedrive/pull/1862

^Triage: 2.4.17 is a bugfix release, MFH candidate
Comment 2 Hiroo Ono 2022-05-21 04:57:36 UTC 
Thank you for the notice. I will prepare the patch for 2.7.17.
It may take some time, as build time for llvm* is quite long.
Comment 3 Hiroo Ono 2022-05-21 13:06:36 UTC 
Created attachment 234080 [details]
update patch to 2.4.17
Comment 4 Graham Perrin freebsd_committer freebsd_triage 2022-05-21 20:07:34 UTC 
Thanks, people. Looking forward to an update in due course.
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2022-05-25 02:46:48 UTC 
(In reply to Hiroo Ono from comment #3)
BTW, when submitting patches to existing ports, patches generated by `git format-patch` are preferred and will save time for the committer. See porter's handbook.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-05-25 06:04:16 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=89404b6aa1f337f431d1ad6521a0c20f9c6cbb3f

commit 89404b6aa1f337f431d1ad6521a0c20f9c6cbb3f
Author:     Hiroo Ono <hiroo.ono+freebsd@gmail.com>
AuthorDate: 2022-05-25 02:48:35 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-05-25 04:20:40 +0000

    net/onedrive: Update to 2.4.17

    Changes:        https://github.com/abraunegg/onedrive/blob/v2.4.17/CHANGELOG.md
    PR:             264112
    MFH:            2022Q2

 net/onedrive/Makefile | 2 +-
 net/onedrive/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-05-25 06:05:17 UTC 
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6ace3810ab0bf2a79d24582a6671943fb807374e

commit 6ace3810ab0bf2a79d24582a6671943fb807374e
Author:     Hiroo Ono <hiroo.ono+freebsd@gmail.com>
AuthorDate: 2022-05-25 02:48:35 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-05-25 06:04:03 +0000

    net/onedrive: Update to 2.4.17

    Changes:        https://github.com/abraunegg/onedrive/blob/v2.4.17/CHANGELOG.md
    PR:             264112
    MFH:            2022Q2
    (cherry picked from commit 89404b6aa1f337f431d1ad6521a0c20f9c6cbb3f)

 net/onedrive/Makefile | 2 +-
 net/onedrive/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 8 Koichiro Iwao freebsd_committer freebsd_triage 2022-05-25 06:06:16 UTC 
Committed, thanks!
Comment 9 Graham Perrin freebsd_committer freebsd_triage 2022-05-25 21:18:32 UTC 
Working. Thanks!