Bug 264254

Summary:	security/keepassxc: Fails to link on 14-CURRENT: ld: error: unknown argument '--no-add-needed'
Product:	Ports & Packages	Reporter:	Cy Schubert <cy>
Component:	Individual Port(s)	Assignee:	Li-Wen Hsu <lwhsu>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	cy, rhurlin
Priority:	---	Keywords:	needs-qa
Version:	Latest	Flags:	bugzilla: maintainer-feedback? (lwhsu) koobs: merge-quarterly?
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264225

Description Cy Schubert freebsd_committer

2022-05-26 12:57:57 UTC

security/keepassxc fails on 14-CURRENT with the following error.

[ 11% 46/371] : && /usr/local/libexec/ccache/c++ -O2 -pipe -Wno-tautological-overlap-compare -fstack-protector-strong -fno-strict-aliasing -fno-common -fopenmp=libomp -Wall -Wextra -Wundef -Wpointer-arith -Wno-long-long -Wformat=2 -Wmissing-format-attribute -fvisibility=hidden -fvisibility-inlines-hidden -fstack-protector-strong -Wnon-virtual-dtor -Wold-style-cast -Woverloaded-virtual -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Werror=format-security -Wcast-align -Qunused-arguments -Wno-deprecated-declarations -O2 -pipe -Wno-tautological-overlap-compare -fstack-protector-strong -fno-strict-aliasing -L/usr/local/lib -fstack-protector-strong -Wl,--no-add-needed -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro,-z,now -pie    -fPIE -pie src/proxy/CMakeFiles/keepassxc-proxy.dir/keepassxc-proxy_autogen/mocs_compilation.cpp.o src/proxy/CMakeFiles/keepassxc-proxy.dir/__/browser/BrowserShared.cpp.o src/proxy/CMakeFiles/keepassxc-proxy.dir/keepassxc-proxy.cpp.o src/proxy/CMakeFiles/keepassxc-proxy.dir/NativeMessagingProxy.cpp.o -o src/proxy/keepassxc-proxy  -Wl,-rpath,/usr/local/lib/qt5:  src/proxy/libproxy_alloc.a  /usr/local/lib/qt5/libQt5Network.so.5.15.2  /usr/local/lib/libbotan-2.so  /usr/local/lib/qt5/libQt5Core.so.5.15.2 && :
FAILED: src/proxy/keepassxc-proxy 
: && /usr/local/libexec/ccache/c++ -O2 -pipe -Wno-tautological-overlap-compare -fstack-protector-strong -fno-strict-aliasing -fno-common -fopenmp=libomp -Wall -Wextra -Wundef -Wpointer-arith -Wno-long-long -Wformat=2 -Wmissing-format-attribute -fvisibility=hidden -fvisibility-inlines-hidden -fstack-protector-strong -Wnon-virtual-dtor -Wold-style-cast -Woverloaded-virtual -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Werror=format-security -Wcast-align -Qunused-arguments -Wno-deprecated-declarations -O2 -pipe -Wno-tautological-overlap-compare -fstack-protector-strong -fno-strict-aliasing -L/usr/local/lib -fstack-protector-strong -Wl,--no-add-needed -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro,-z,now -pie    -fPIE -pie src/proxy/CMakeFiles/keepassxc-proxy.dir/keepassxc-proxy_autogen/mocs_compilation.cpp.o src/proxy/CMakeFiles/keepassxc-proxy.dir/__/browser/BrowserShared.cpp.o src/proxy/CMakeFiles/keepassxc-proxy.dir/keepassxc-proxy.cpp.o src/proxy/CMakeFiles/keepassxc-proxy.dir/NativeMessagingProxy.cpp.o -o src/proxy/keepassxc-proxy  -Wl,-rpath,/usr/local/lib/qt5:  src/proxy/libproxy_alloc.a  /usr/local/lib/qt5/libQt5Network.so.5.15.2  /usr/local/lib/libbotan-2.so  /usr/local/lib/qt5/libQt5Core.so.5.15.2 && :
ld: error: unknown argument '--no-add-needed'
c++: error: linker command failed with exit code 1 (use -v to see invocation)

Comment 1 Cy Schubert freebsd_committer

2022-05-26 12:58:19 UTC

I am testing a patch.

Comment 2 Rainer Hurling freebsd_committer

2022-05-26 14:13:34 UTC

(In reply to Cy Schubert from comment #1)
Did you try the patch in bug #264225 ?

Comment 3 Cy Schubert freebsd_committer

2022-05-26 14:31:31 UTC

(In reply to Rainer Hurling from comment #2)

The patch I'm testing does the same thing. It removes the non-Apple test.

Comment 4 Li-Wen Hsu freebsd_committer

2022-05-29 16:29:38 UTC

The patch in bug264225 has been committed and let's track the follow up actions there.