Bug 264402
| Summary: | net/fping: Avoid ident collisions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Craig Leres <leres> | ||||
| Component: | Individual Port(s) | Assignee: | Craig Leres <leres> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | jharris | ||||
| Priority: | --- | Flags: | jharris:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Approved, albeit with personally testing it. A regular patch is fine. Thanks! Created attachment 234386 [details]
patch
Comment on attachment 234386 [details]
patch
Looks good to me.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=65d71ce9bdd96d79b5c9cffafc144fe23ebf6b15 commit 65d71ce9bdd96d79b5c9cffafc144fe23ebf6b15 Author: Craig Leres <leres@FreeBSD.org> AuthorDate: 2022-06-02 00:46:21 +0000 Commit: Craig Leres <leres@FreeBSD.org> CommitDate: 2022-06-02 00:46:21 +0000 net/fping: Avoid ident collisions fping derives the ident it puts in the outbound packet to from the low 16 bits of the process id. This means a busy nagios server can see collisions. More details on this issue and a patch to solve it here: https://github.com/schweikert/fping/issues/206 Apply the patch from the github issue: PR: 264402 Reported by: Case Larsen Approved by: jharris (maintainer) net/fping/Makefile | 2 +- net/fping/files/patch-fping.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) Thanks for the fast resolution; committed! |
We have a busy nagios server and its not unusual for there to be 200 fping's running simultaneously. Since fping derives the ident it puts in the outbound packet to from the low 16 bits of the process id, we see collisions. Here's a github pull request that fixes this issue: https://github.com/schweikert/fping/issues/206 If I create a patch for the fping port to make this change would you prefer a patch an an optional patch?