Bug 264628
| Summary: | irc/irssi: Update to 1.4.1 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Daniel Engberg <diizzy> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | dor.bsd, niels=freebsd | ||||||||||
| Priority: | --- | Flags: | dor.bsd:
maintainer-feedback+
|
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| URL: | https://github.com/irssi/irssi/releases/tag/1.4.1 | ||||||||||||
| Attachments: |
|
||||||||||||
Tracked upstream, https://github.com/irssi/irssi/issues/1385 Created attachment 234659 [details]
Patch for irssi v2
Backport upstream commit a5f5ea7d79274fcf547ef81f019b0c38c6863051 to fix channel prefix issue
Created attachment 234684 [details]
Patch for irssi v3
Update pkg-message as per advice by upstream
Sorry for the delay here, I've been pretty busy recently. Taking a look at this patch now, thank you. Comment on attachment 234684 [details]
Patch for irssi v3
Looks good, thanks.
The only thing I'm unsure of is the decrease of PORTEPOCH, since the handbook says it never decreases.
Epoch indeed shouldn't decrease. Otherwise, the patch works for me. I maintained my own tree for a while and missed it while porting it back. Thanks for making me aware. I also lost the backport patch in v3 but I'll add that back when committing Created attachment 235116 [details] Patch for irssi v4 Fix PORTEPOCH Backport upstream commits from maintenance branch: 3404d822c83546b031d47a99e37ae65b887bec94 f17fb682573985656fa26bf10370b9e1d88e3bdf c6a7f02042f63d01a38e8d522cff8f5d951afd51 730c3c1a12f782b92d710883f52a106e37f148e4 1b6b92ffff6950ee28c1b7936f53d83988843ed4 References: https://github.com/ailin-nemui/irssi/commit/3404d822c83546b031d47a99e37ae65b887bec94 https://github.com/ailin-nemui/irssi/commit/f17fb682573985656fa26bf10370b9e1d88e3bdf https://github.com/ailin-nemui/irssi/commit/c6a7f02042f63d01a38e8d522cff8f5d951afd51 https://github.com/ailin-nemui/irssi/commit/730c3c1a12f782b92d710883f52a106e37f148e4 https://github.com/ailin-nemui/irssi/commit/1b6b92ffff6950ee28c1b7936f53d83988843ed4 This should be the final one, please review Comment on attachment 235116 [details]
Patch for irssi v4
Looks good!
Thanks for showing off the PATCH_SITES stuff too, that's really neat.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bc97cc7b70dea8f491605a7670932805dcb9ea97 commit bc97cc7b70dea8f491605a7670932805dcb9ea97 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-07-09 21:39:44 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-07-09 21:49:32 +0000 irc/irssi: Update to 1.4.1 Changelog: https://github.com/irssi/irssi/releases/tag/1.4.1 Backport upstream commits from maintenance branch: 3404d822c83546b031d47a99e37ae65b887bec94 f17fb682573985656fa26bf10370b9e1d88e3bdf c6a7f02042f63d01a38e8d522cff8f5d951afd51 730c3c1a12f782b92d710883f52a106e37f148e4 1b6b92ffff6950ee28c1b7936f53d83988843ed4 References: https://github.com/ailin-nemui/irssi/commit/3404d822c83546b031d47a99e37ae65b887bec94 https://github.com/ailin-nemui/irssi/commit/f17fb682573985656fa26bf10370b9e1d88e3bdf https://github.com/ailin-nemui/irssi/commit/c6a7f02042f63d01a38e8d522cff8f5d951afd51 https://github.com/ailin-nemui/irssi/commit/730c3c1a12f782b92d710883f52a106e37f148e4 https://github.com/ailin-nemui/irssi/commit/1b6b92ffff6950ee28c1b7936f53d83988843ed4 PR: 264628 Reviewed by: David O'Rourke <dor.bsd@xm0.uk> (maintainer) irc/irssi/Makefile | 81 +++++----- irc/irssi/distinfo | 14 +- irc/irssi/files/patch-Makefile.in (gone) | 22 --- irc/irssi/files/patch-configure.ac (gone) | 15 -- ...-f17fb682573985656fa26bf10370b9e1d88e3bdf (new) | 172 +++++++++++++++++++++ irc/irssi/files/patch-perl-Makefile (gone) | 22 --- irc/irssi/pkg-message (new) | 8 + irc/irssi/pkg-plist | 11 +- 8 files changed, 232 insertions(+), 113 deletions(-) Thanks |
Created attachment 234633 [details] Patch for irssi * Use DISTVERSION instead of PORTVERSION as per Porters Handbook * Switch to Meson Compile and run-tested on 13.1-RELEASE (aarch64) Poudriere testport OK 12.3-RELEASE (amd64) Poudriere testport OK 13.1-RELEASE (i386) Note: The only different(?) behaviour I've noticed is that /j somechannel defaults to &somechannel rather than #somechannel Botti compiles despite what the release notice says. Perl module is untested as I don't use it.