Bug 264735

Summary: net-mgmt/netdata: 1.35.1 fails to install freeipmi plugin with FREEIPMI=on
Product: Ports & Packages Reporter: florian.millet
Component: Individual Port(s)Assignee: Neel Chauhan <nc>
Status: Closed FIXED    
Severity: Affects Some People Keywords: regression
Priority: --- Flags: nc: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   

Description florian.millet 2022-06-17 12:58:55 UTC
With the latest commit to update netdata to version 1.35.1 the port no longer installs the freeipmi plugin file even if the option is activated.

comparing with an old version netdata-1.34.1 :

#pkg info netdata | grep -i ipmi
        FREEIPMI       : on
#pkg info -l netdata | grep -i ipmi
        /usr/local/lib/netdata/conf.d/health.d/ipmi.conf.sample
        /usr/local/libexec/netdata/plugins.d/freeipmi.plugin

the new version netdata-1.35.1 :

#pkg info netdata | grep -i ipmi
        FREEIPMI       : on
#pkg info -l netdata | grep -i ipmi
        /usr/local/lib/netdata/conf.d/health.d/ipmi.conf.sample

it would seem some optionnal files were removed from the pkg-plist file in the last commit.
This problem probably is present for the other options (CUPS, GOPLUGIN, etc..).
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-06-17 15:10:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a4036fa1b01ec4064ccda9763d980fe40fa86cb0

commit a4036fa1b01ec4064ccda9763d980fe40fa86cb0
Author:     Neel Chauhan <nc@FreeBSD.org>
AuthorDate: 2022-06-17 15:08:48 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-06-17 15:08:48 +0000

    net-mgmt/netdata: Fix pkg-plist if FREEIPMI option is set

    PR:             264735
    Reported by:    florian.millet@laposte.net

 net-mgmt/netdata/pkg-plist | 1 +
 1 file changed, 1 insertion(+)
Comment 2 Neel Chauhan freebsd_committer freebsd_triage 2022-06-17 15:10:36 UTC
I committed a fix. Does it work now?
Comment 3 florian.millet 2022-06-17 15:41:16 UTC
Hello,

I can confirm that the file is now correctly installed with your fix.
Thank you for the quick answer.