Bug 264824

Summary: net/vde2: fix build with PYTHON with python3.10 or update to 2.3.3 without python support
Product: Ports & Packages Reporter: Vladimir Druzenko <vvd>
Component: Individual Port(s)Assignee: Dima Panov <fluffy>
Status: Closed FIXED    
Severity: Affects Many People CC: diizzy, fluffy
Priority: --- Flags: vvd: maintainer-feedback?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
python 3.10 detection
vvd: maintainer-approval?
Update to 2.3.3 vvd: maintainer-approval?

Description Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-22 11:40:05 UTC
Created attachment 234853 [details]
python 3.10 detection

Before patch:
checking whether /usr/local/bin/python3.10 version >= 2.5... yes
checking for /usr/local/bin/python3.10 version... 3.1
checking for /usr/local/bin/python3.10 platform... freebsd13
checking for /usr/local/bin/python3.10 script directory... ${prefix}/lib/python3.10/site-packages
checking for /usr/local/bin/python3.10 extension module directory... ${exec_prefix}/lib/python3.10/site-packages
checking for python3.1-config... no
checking for python-config... no

$ python -c "import sys; sys.stdout.write(sys.version[:3])"
3.1

$ python -c "import sys; sys.stdout.write(str(sys.version_info[0])+'.'+str(sys.version_info[1]))"
3.10

After patch:
checking whether /usr/local/bin/python3.10 version >= 2.5... yes
checking for /usr/local/bin/python3.10 version... 3.10
checking for /usr/local/bin/python3.10 platform... freebsd13
checking for /usr/local/bin/python3.10 script directory... ${prefix}/lib/python3.10/site-packages
checking for /usr/local/bin/python3.10 extension module directory... ${exec_prefix}/lib/python3.10/site-packages
checking for python3.10-config... /usr/local/bin/python3.10-config
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-22 11:50:59 UTC
Created attachment 234855 [details]
Update to 2.3.3

Tested build only on 13.1 amd64.

In 2.3.3 python support was dropped.
Module vde_cryptcab require security/wolfssl - added option CRYPTCAB.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-06-26 06:13:57 UTC
The 2.3.3 patch needs a bit of work

It should use USE_GITHUB
CRYPTCAB_*FLAGS should be replaced by USES= localbase:ldflags
CRYPTCAB should have the following order (to follow general order in Makefiles):

CRYPTCAB_LIB , CRYPTCAB_USES, CRYPTCAB_CONFIGURE_ENABLE

net/vde2/files/patch-src__dpipe.c needs upstreaming?

Do we still need L25 and L26?

Best regards,
Daniel
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-07-02 21:32:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=17ae8ac447413deb6594a0681d426fe21000caf4

commit 17ae8ac447413deb6594a0681d426fe21000caf4
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2022-07-02 21:28:11 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2022-07-02 21:31:01 +0000

    net/vde2: update to 2.3.3 release (+)

    Upstream switched to GitHub
    Cryptcab support now require WolfSSL instead of OpenSSL

    PR:     264824

 net/vde2/Makefile                                  |  35 +++----
 net/vde2/distinfo                                  |   5 +-
 net/vde2/files/patch-src__dpipe.c                  |   6 +-
 .../patch-src_vde__cryptcab_cryptcab.c (gone)      | 110 ---------------------
 net/vde2/files/patch-src_vde__l3_vde__l3.c (gone)  |  23 -----
 net/vde2/files/patch-src_vde__switch_fstp.c (gone) |  18 ----
 net/vde2/pkg-plist                                 |  16 +--
 7 files changed, 28 insertions(+), 185 deletions(-)
Comment 4 Dima Panov freebsd_committer freebsd_triage 2022-07-02 22:41:50 UTC
Update committed with minor style adjustments, thanks!