Bug 264857

Summary: www/firefox: compilation fails due to SSE not being available
Product: Ports & Packages Reporter: Martin Birgmeier <d8zNeCFG>
Component: Individual Port(s)Assignee: Christoph Moench-Tegeder <cmt>
Status: Closed FIXED    
Severity: Affects Only Me CC: cmt, grahamperrin, jcfyecrayz
Priority: --- Flags: bugzilla: maintainer-feedback? (gecko)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
portmaster log from second invocation none

Description Martin Birgmeier 2022-06-23 18:53:45 UTC 
Scenario:
- FreeBSD 12.3 i386 (it is working on amd64)
- latest ports
- using portmaster to upgrade all ports
- portmaster tries to upgrade firefox-101.0.1,2 to firefox-102.0,2

Result:
- The build fails with

third_party/libwebrtc/third_party/pffft/src/pffft.c:243:3: error: always_inline function '_mm_movehl_ps' requires target feature 'sse', but would be inlined into function 'validate_pffft_simd' that is compiled without support for 'sse'

Expected result:
- The compile should succeed (as it did for the previous version firefox-101.0.1,2)

A log file from running portmaster again after the first abort is attached.

-- Martin
Comment 1 Martin Birgmeier 2022-06-23 18:55:07 UTC 
Created attachment 234901 [details]
portmaster log from second invocation
Comment 2 Martin Birgmeier 2022-06-25 05:55:40 UTC 
The issue persists with firefox-102.0_1,2.

-- Martin
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-07-14 18:40:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5db62413655cd5f25756b23012d0e8390f0917c5

commit 5db62413655cd5f25756b23012d0e8390f0917c5
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2022-07-14 18:38:39 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2022-07-14 18:38:39 +0000

    www/firefox: regenerate libwebrtc build files

    this seems to fix the build on i386.

    PR:             264857

 www/firefox/files/patch-libwebrtc-generated | 7021 ++++++++++++++-------------
 1 file changed, 3682 insertions(+), 3339 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-14 18:41:04 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5917f7dc6a6d1dd2075b6efde550777e14ac7bca

commit 5917f7dc6a6d1dd2075b6efde550777e14ac7bca
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2022-07-14 18:38:39 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2022-07-14 18:39:58 +0000

    www/firefox: regenerate libwebrtc build files

    this seems to fix the build on i386.

    PR:             264857
    (cherry picked from commit 5db62413655cd5f25756b23012d0e8390f0917c5)

 www/firefox/files/patch-libwebrtc-generated | 7021 ++++++++++++++-------------
 1 file changed, 3682 insertions(+), 3339 deletions(-)
Comment 5 John Hein 2022-11-24 00:28:30 UTC 
Christoph, how does one 'regenerate libwebrtc build files'?  This error ("requires target feature 'sse'") shows up on i386 for the latest firefox (107), too (after applying the patch from bug 266470 to get past that compile error).
Comment 6 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2022-11-24 21:18:59 UTC 
(In reply to John Hein from comment #5)
mach python python/mozbuild/mozbuild/gn_processor.py dom/media/webrtc/third_party_build/gn-configs/webrtc.json
but guess what: https://cgit.freebsd.org/ports/commit/www/firefox/files?id=80898b526334682fb8e63f1a6e7e2c9029bfa19d
i386 is over, and I don't have the time or motivation to get into retro-computing.