Bug 26507

Summary: [PATCH] fixes to dump(8)
Product: Base System Reporter: dd <dd>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description dd freebsd_committer freebsd_triage 2001-04-12 09:10:01 UTC 
Attached is a patch that makes some [relatively minor] fixes to
src/sbin/dump/traverse.c.  Most of these bugs were caused by incorrect
assumptions I made when porting over NetBSD's code to handle the
nodump filesystem flag on directories (revs. 1.12 and 1.10.2.2).

The first two hunks' purpose should be pretty obvious from the comment
update; basically, mapdirs() tests directory inodes for being in
dumpdirmap but not in usedinomap to detect whether that directory has
inherited, or has set, the nodump flag.  Currently, this test will
fail when it shouldn't when doing a dump with level > 0 and when no
directories on the filesystem were changed.

The third hunk corrects a small bogon with regards to handling the -h
option.

Fix: Apply the following patch to src/sbin/dump/traverse.c:
Comment 1 dd freebsd_committer freebsd_triage 2001-04-20 09:11:31 UTC 
State Changed
From-To: open->closed

Patch committed by jkh to both -current and -stable.