Bug 265141

Summary: net/self-service-password: Update to 1.4.5
Product: Ports & Packages Reporter: geraud
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Many People CC: eduardo, fernape, ports-secteam, ports
Priority: Normal Flags: ports: maintainer-feedback+
fernape: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/ltb-project/self-service-password/releases/tag/v1.4.5
Attachments:
Description Flags
Update to 1.4.5
none
Update to 1.4.5 fernape: maintainer-approval+

Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-11 07:31:03 UTC 
Hi,

1. PLIST_SUB fix:
---
+PLIST_SUB+=    SSP_GRP=${WWWGRP} \
+               SSP_OWN=${WWWOWN}
-PLIST_SUB+=    SSP_OWN=${WWWOWN}
-PLIST_SUB+=    SSP_GRP=${WWWGRP}
---

2. PLIST issues:
---
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%WWWDIR%%/lib/vendor/phpmailer/phpmailer/language/phpmailer.lang-sr_latn.php
Error: Orphaned: %%WWWDIR%%/rest/v1/adminchangepassword.php
Error: Orphaned: %%WWWDIR%%/rest/v1/changepassword.php
Error: Orphaned: %%WWWDIR%%/rest/v1/checkpassword.php
Error: Orphaned: %%WWWDIR%%/rest/v1/doc/openapi-spec.yaml
Error: Orphaned: %%WWWDIR%%/rest/v1/include.php
Error: Orphaned: @dir %%WWWDIR%%/lib/vendor/bin
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
---
Comment 2 Krzysztof 2022-07-11 07:32:08 UTC 
Comment on attachment 235178 [details]
Update to 1.4.5

I approve
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-11 08:20:18 UTC 
(In reply to Krzysztof from comment #2)
Please click on patch details to set approval flag and don't forget about plist issues that need to be fixed.

Cheers
Comment 4 geraud 2022-07-11 22:27:38 UTC 
Created attachment 235198 [details]
Update to 1.4.5

Takes into account the modifications requested by eduardo@

Thanks
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-12 05:51:06 UTC 
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!
Comment 6 Krzysztof 2022-07-12 05:51:47 UTC 
Comment on attachment 235198 [details]
Update to 1.4.5

approved
Comment 7 Krzysztof 2022-07-12 05:54:22 UTC 
I'm trying to set flag on attachment but there is no result. Am I doing sth wrong?
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-12 06:14:43 UTC 
(In reply to Krzysztof from comment #7)
Not sure. I did it for you. Have you had this problem before?

Thanks!
Comment 9 Krzysztof 2022-07-12 08:28:54 UTC 
(In reply to Fernando Apesteguía from comment #8)
No. If I was pr owner I have no such problems... 

Hmm. I will try next time. Maybe some browser plugins is blocking something? I don't know...
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-07-12 20:45:09 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c0143e06173e06d1712532046179e794b8627744

commit c0143e06173e06d1712532046179e794b8627744
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-07-12 05:49:53 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-12 20:40:34 +0000

    net/self-service-password: Update to 1.4.5

    ChangeLog:
    https://github.com/ltb-project/self-service-password/releases/tag/v1.4.5

    v1.4.3[1] included security fixes.

    [1] https://github.com/ltb-project/self-service-password/releases/tag/v1.4.3

    PR:     265141
    Reported by:    geraud@gcu.info
    Approved by:    ports@bsdserwis.com (maintainer)
    MFH:    2022Q3 (bugfixes, including security fixes)

 net/self-service-password/Makefile  | 7 +++----
 net/self-service-password/distinfo  | 6 +++---
 net/self-service-password/pkg-descr | 2 +-
 net/self-service-password/pkg-plist | 7 +++++++
 4 files changed, 14 insertions(+), 8 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2022-07-12 20:46:10 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=71c23c68e6830ce247e30421b0472298fbe64b6a

commit 71c23c68e6830ce247e30421b0472298fbe64b6a
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-07-12 05:49:53 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-12 20:43:03 +0000

    net/self-service-password: Update to 1.4.5

    ChangeLog:
    https://github.com/ltb-project/self-service-password/releases/tag/v1.4.5

    v1.4.3[1] included security fixes.

    [1] https://github.com/ltb-project/self-service-password/releases/tag/v1.4.3

    PR:     265141
    Reported by:    geraud@gcu.info
    Approved by:    ports@bsdserwis.com (maintainer)
    MFH:    2022Q3 (bugfixes, including security fixes)

    (cherry picked from commit c0143e06173e06d1712532046179e794b8627744)

 net/self-service-password/Makefile  | 7 +++----
 net/self-service-password/distinfo  | 6 +++---
 net/self-service-password/pkg-descr | 2 +-
 net/self-service-password/pkg-plist | 7 +++++++
 4 files changed, 14 insertions(+), 8 deletions(-)
Comment 12 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-12 20:46:21 UTC 
Committed and merged to 2022Q3,

Thanks!