Bug 265563

Summary: dns/blocky: Add buildinfo symbols to -ldflags
Product: Ports & Packages Reporter: Daniel Ponte <amigan>
Component: Individual Port(s)Assignee: Nuno Teixeira <eduardo>
Status: Closed FIXED    
Severity: Affects Some People Keywords: needs-qa
Priority: --- Flags: eduardo: maintainer-feedback+
eduardo: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile diff eduardo: maintainer-approval+

Description Daniel Ponte 2022-08-02 01:04:34 UTC
Created attachment 235623 [details]
Makefile diff

This patch adds the buildinfo symbols to -ldflags so they do not show up as "undefined". The port's regular Makefile does this, but obviously USES_GO does not.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-08-02 01:07:03 UTC
Is quarterly port version also affected? If so, please set the merge-quarterly flag to ?
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-08-02 01:56:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=76d7410873ef215e2451c0cb3152bfe0a82656c4

commit 76d7410873ef215e2451c0cb3152bfe0a82656c4
Author:     Daniel Ponte <amigan@gmail.com>
AuthorDate: 2022-08-02 01:51:31 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-08-02 01:51:31 +0000

    dns/blocky: Add buildinfo symbols to -ldflags

     - add buildinfo symbols to -ldflags so they do not show up as
       "undefined"
     - bump PORTREVISION

    PR:             265563

 dns/blocky/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-02 02:06:33 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=36b56411eec6d262619f802d0d10e37f93850225

commit 36b56411eec6d262619f802d0d10e37f93850225
Author:     Daniel Ponte <amigan@gmail.com>
AuthorDate: 2022-08-02 01:51:31 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-08-02 02:05:08 +0000

    dns/blocky: Add buildinfo symbols to -ldflags

     - add buildinfo symbols to -ldflags so they do not show up as
       "undefined"
     - bump PORTREVISION

    PR:             265563
    (cherry picked from commit 76d7410873ef215e2451c0cb3152bfe0a82656c4)

 dns/blocky/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-02 02:09:36 UTC
Committed, thank you!