Bug 265571

Summary: irc/irssi-xmpp: Fix build with irssi 1.4
Product: Ports & Packages Reporter: Thibault Jouan <tj+freebsd_ports>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Some People CC: diizzy, fernape
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
irc/irssi-xmpp: Fix build with irssi 1.4
none
irc/irssi-xmpp: Improve patches with full hashes none

Description Thibault Jouan 2022-08-02 11:12:14 UTC 
Created attachment 235631 [details]
irc/irssi-xmpp: Fix build with irssi 1.4

Following bug #259122, here is my attempt to unbreak irssi-xmpp.

The original master site now redirects to the github page, so I had to change it.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-08-04 06:09:50 UTC 
^Triage: [tags] in issue Titles are deprecated.

Thanks!
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-08-05 05:34:42 UTC 
Committed,

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-05 05:35:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=079567cc48874444ea2cad0b91b00040e7a1ddc9

commit 079567cc48874444ea2cad0b91b00040e7a1ddc9
Author:     Thibault Jouan <tj+freebsd_ports@a13.fr>
AuthorDate: 2022-08-04 06:08:46 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-08-05 05:31:25 +0000

    irc/irssi-xmpp: Fix build with irssi 1.4

    PR:     265571
    Reported by:    tj+freebsd_ports@a13.fr

 irc/irssi-xmpp/Makefile                             | 21 +++++++++++++++------
 irc/irssi-xmpp/distinfo                             | 10 +++++++---
 .../patch-src_fe-common_xmpp-completion.c (new)     | 17 +++++++++++++++++
 3 files changed, 39 insertions(+), 9 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-08-05 06:07:30 UTC 
Nice work!

Please use full hashes for patch files as they go directly into distfiles directory to avoid name clashes

What's the origin of patch-src_fe-common_xmpp-completion.c ?
Comment 5 Thibault Jouan 2022-08-06 10:01:49 UTC 
Created attachment 235717 [details]
irc/irssi-xmpp: Improve patches with full hashes

Thanks for the commit and the feedback.

This new patch changes the commit hashes for patch files, full instead of shortened. I saw this in another port and thought it was a good idea to avoid long lines with the comments. I moved comments on a separate line but can also remove them if preferred.

> What's the origin of patch-src_fe-common_xmpp-completion.c ?

The first patch mentioned in this comment:
https://github.com/cdidier/irssi-xmpp/issues/56#issue-1271790399
(the second one is already covered by one of the `PATCHFILES' fetched from GitHub)
I added a line in the patch file to mention the "source".
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2022-08-06 19:12:38 UTC 
Thanks, I'll do the additional commit.