Bug 265704
| Summary: | textproc/opensearch: Add plugins config files | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jose Alonso Cardenas Marquez <acm> | ||||||||
| Component: | Individual Port(s) | Assignee: | opensearch | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | admin, romain | ||||||||
| Priority: | --- | Flags: | admin:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 235798 [details]
testport failed with pkg-plist
Thanks for the improvements. Testport failed with the given pkg-plist.
Could you check the patch again?
(In reply to Sven Ruediger from comment #1) I forget add OPTIONS_SUB to Makefile. Please add it to Makefile and try again. Something like the following OPTIONS_DEFINE= PLUGINS OPTIONS_DEFAULT=PLUGINS +OPTIONS_SUB= yes Created attachment 235815 [details]
patch v2
Looks good. Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=914541c1f3ffcf8ef7559ce59e17b33cee85e752 commit 914541c1f3ffcf8ef7559ce59e17b33cee85e752 Author: Romain Tartière <romain@FreeBSD.org> AuthorDate: 2022-08-19 22:26:29 +0000 Commit: Romain Tartière <romain@FreeBSD.org> CommitDate: 2022-08-20 00:13:34 +0000 textproc/opensearch: Install plugins config files PR: 265704 Reported by: acm textproc/opensearch/Makefile | 45 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=43c14b71d3e7212d18e14b44911abffc99f40c9b commit 43c14b71d3e7212d18e14b44911abffc99f40c9b Author: Romain Tartière <romain@FreeBSD.org> AuthorDate: 2022-08-20 00:11:13 +0000 Commit: Romain Tartière <romain@FreeBSD.org> CommitDate: 2022-08-20 00:13:34 +0000 textproc/opensearch: Switch to a static pkg-plist PR: 265704 Reported by: acm textproc/opensearch/Makefile | 13 +- textproc/opensearch/pkg-plist (new) | 599 ++++++++++++++++++++++++++++++++++++ 2 files changed, 600 insertions(+), 12 deletions(-) Committed with some modifications: upstream does not setup opensearch-security/opensearch.yml and only provide an example file, so I think it's better for us to do something similar. The static pkg-plist might quickly become a PITA, I ensured it is in a dedicated commit so that we can revert it if juggling with each jar file version number starts to be too boring. Thanks! |
Created attachment 235765 [details] update patch file v1 Hi, I'm testing opensearch with wazuh manager and I see opensearch port doesn't install plugins configuration files. It can be helful for users using some opensearch plugin. Also it is recommended use static pkg-plist instead of dynamic one