Bug 265798
| Summary: | editors/vim: add (default) option to install legacy color schemes as well | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Michael Osipov <michael.osipov> | ||||
| Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | michael.osipov | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(adamw) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Michael Osipov
2022-08-12 15:48:01 UTC
What about a new vim-colorschemes-legacy port? I think I'd rather package vim as provided by upstream, but a new port would allow them to be installed and updated independently. (In reply to Adam Weinberger from comment #1) That would work as well, of course. Please note that my proposal does NOT override new schemes, but simply puts the old ones into a subdir 'legacy/'. Understood. I think it's a good idea. I'd be happy to add that port if you make a patch for it. (In reply to Adam Weinberger from comment #3) Yes, let me work on it this week. If you want to put it in $VIMRUNTIME, this may be helpful:
VIMRUNTIME!= make -C "${.CURDIR}/../vim" -V '${DATADIR}/${VIM_VER}'
DATADIR:= ${VIMRUNTIME}/colors/legacy
So that the pkg-plist could do:
%%DATADIR%%/somecolorscheme.vim
(In reply to Adam Weinberger from comment #5) Thanks for the tip. Yes, I want to put it there to make it easy to say: :colorscheme legacy/{color} Created attachment 235993 [details]
Git-formatted patch
Here is a patch which adds the legacy color schemes. Tested in a poudriere jail: poudriere testport -j 123-release-amd64 -p default-main editors/vim-colorschemes-legacy
Let me know what you think
This is a good patch! Locally I just made a few small changes (${LOCALBASE}/bin/ is unnecessary, stuff like that).
You sure you don't want to maintain it? The maintenance cost is probably pretty low (I doubt those colorschemes will ever change).
(In reply to Adam Weinberger from comment #8) Then make me maintainer: michael.osipov@siemens.com When you are going to commit this, please back port to quarterly as well. I guess this change may be disruptive in quarterly as well. Maybe you need to add a message to UPDATING to restore previous state. (In reply to Michael Osipov from comment #10) New ports generally aren't backported to quarterly. A new quarterly will branch in a matter of weeks, and this port will be included in it. (In reply to Adam Weinberger from comment #11) Well, rather 6 weeks. Then I need to roll it out manually on all machines for consistency reasons. I wouldn't really say it is new because quarterly is used to reduce maintenance and surprises and that change from the vim creators is a surprise for many. Adam, is anything holding you off to apply to main? (In reply to Michael Osipov from comment #13) $IRL. It's on my list. I'll get it in for the next vim update if not before. (In reply to Adam Weinberger from comment #14) Thanks, looking forward to! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c51ce87a4ef535f7df2c31bbf8b1cbd1a0f1d579 commit c51ce87a4ef535f7df2c31bbf8b1cbd1a0f1d579 Author: Adam Weinberger <adamw@FreeBSD.org> AuthorDate: 2022-09-03 16:26:48 +0000 Commit: Adam Weinberger <adamw@FreeBSD.org> CommitDate: 2022-09-03 16:26:48 +0000 editors/vim-colorschemes-legacy: Add port Upstream vim modernized their colorschemes, which is a good thing. However, the look of them has changed, which is jarring at best for users used to the original look. Upstream colorscheme development was split into a new repo, and the original colorschemes were imported there. This port installs those colorschemes. The rest of that repo are the colorschemes included in vim, so there's not really any benefit to packaging anything else from it. PR: 265798 editors/Makefile | 1 + editors/vim-colorschemes-legacy/Makefile (new) | 33 +++++++++ editors/vim-colorschemes-legacy/distinfo (new) | 3 + .../vim-colorschemes-legacy/files/LICENSE (new) | 78 ++++++++++++++++++++++ editors/vim-colorschemes-legacy/pkg-descr (new) | 7 ++ editors/vim-colorschemes-legacy/pkg-plist (new) | 17 +++++ 6 files changed, 139 insertions(+) Sorry about the big delay in getting this in. Things have been crazy here. It is committed finally! Thanks for your work on making this port, Michael. |
