Bug 266008
| Summary: | net/linphone: 4.4.8_1: broken plugin dir path | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ruslan Zalata <rz> | ||||
| Component: | Individual Port(s) | Assignee: | Felix Palmen <zirias> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | zirias:
maintainer-feedback+
|
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 266006 | ||||||
| Attachments: |
|
||||||
Created attachment 236084 [details]
Patch CMakeLists.txt to set MSPLUGINS_DIR correctly
Ok, the problem caused by wrongly set MSPLUGINS_DIR is CMakeLists.txt. Here's the patch.
This looks like another fallout from upstream's recent decision to only support building some AppImage (with all dependencies bundled). Thanks for the patch, will test it soon! Patch tested, works for me! I prepared a commit with you as the author adding that patch. If I understood it correctly, it's also necessary to really fix your other PR 266006, so adding it as dependent here. Therefore, I will wait for approval on the updates and fixes of the other ports and then commit everything in one batch. Thanks again for your work! Yes, that's right. Thank you too. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=de2c238aa0a69cd2dcf828f3ae0d80108194f44f commit de2c238aa0a69cd2dcf828f3ae0d80108194f44f Author: Ruslan Zalata <rz@fabmicro.ru> AuthorDate: 2022-08-24 03:52:08 +0000 Commit: Felix Palmen <zirias@FreeBSD.org> CommitDate: 2022-09-05 16:36:20 +0000 net/linphone: Fix mediastreamer plugins dir PR: 266008 Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D36458 net/linphone/Makefile | 2 +- net/linphone/files/patch-CMakeLists.txt (new) | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) Patch committed, thanks! |
After upgrading to net/linphone 4.4.8 I discovered that Linphone no longer loads H264 plugin (msopenh264). Logging with -V has shown that mediastreamers is provided with bogus path to find its plugins: [06:25:03:075][Info]Core:linphone: Loading ms plugins from [/usr/local] It should be /usr/local/lib/mediastreamer/plugins/ instead. I tracked it down to the below code that coins incorrect MS plugin dir path: linphone-app/src/app/paths/Paths.cpp: static inline QString getAppPackageMsPluginsDirPath () { QDir dir = getAppPackageDir(); dir.cd(MSPLUGINS_DIR); return dir.absolutePath(); }