Bug 266034
| Summary: | [exp-run] Mk/Uses: always use colon for build/run suffix | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Felix Palmen <zirias> |
| Component: | Ports Framework | Assignee: | Felix Palmen <zirias> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | kde, ports-bugs, tcberner |
| Priority: | --- | Flags: | tcberner:
maintainer-feedback+
antoine: exp-run+ |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| URL: | https://reviews.freebsd.org/D36349 | ||
| Attachments: | |||
|
Description
Felix Palmen
2022-08-25 15:33:45 UTC
Created attachment 236114 [details] 0001-Mk-Uses-always-use-colon-for-build-run-suffix-v2 Error handling improved thanks to input from tcberner, probably not relevant, but still please use the new patch... attached and to be found here: https://people.freebsd.org/~zirias/patches/0001-Mk-Uses-always-use-colon-for-build-run-suffix-v2.patch Cheers, Felix moin moin Yes, that looks like a sensible change from kde@'s point of view as it unifies the USE_FOO= list handling over the tree. mfg Tobias Created attachment 236123 [details] 0001-Mk-Uses-always-use-colon-for-build-run-suffix-v3 Rebased onto current main, new patch can also be found here: https://people.freebsd.org/~zirias/patches/0001-Mk-Uses-always-use-colon-for-build-run-suffix-v3.patch As this is a constantly moving target, here's how the diff is created from scratch: 1. Apply this patch to only change the framework files: https://people.freebsd.org/~zirias/patches/always-use-colon_Mk-only.patch 2. Run this perl script from the PORTSDIR root to update all ports: https://people.freebsd.org/~zirias/scripts/update-use-kde-qt-pyqt.pl.txt Some new failure logs: http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-09-03_08h27m42s/logs/errors/glmark2-2021.12.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-09-03_08h27m42s/logs/errors/notepadnext-0.5.4.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-09-03_08h27m42s/logs/errors/taucs-2.2_23.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-09-03_08h27m42s/logs/errors/mpv-0.34.1_2,1.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-09-03_08h27m42s/logs/errors/librenms-22.2.1,1.log Please double or triple check the complete patch, as the exp-run was performed only on qt/kde related ports and it seems you patch too much Created attachment 236390 [details] 0001-Mk-Uses-always-use-colon-for-build-run-suffix-v4 (In reply to Antoine Brodin from comment #5) Yes indeed, the patterns derived from the valid USES args matched in a few completely unrelated contexts :( Sorry for not noticing this previously... Adding a bit of context to the matching fixes it for me, at least all the ports that failed are in the list of differences now! Please find attached the fixed complete patch, also available here: https://people.freebsd.org/~zirias/patches/0001-Mk-Uses-always-use-colon-for-build-run-suffix-v4.patch Or, to "manually apply": * Apply this updated patch: https://people.freebsd.org/~zirias/patches/always-use-colon_Mk-only-v2.patch * Run this updated perl script: https://people.freebsd.org/~zirias/scripts/update-use-kde-qt-pyqt-v2.pl.txt Exp-run looks fine. Please triple check the patch before committing |