Bug 266382
| Summary: | emulators/virtualbox-ose: Remove unnecessary dependency on 32-bit compat for amd64 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Olivier Certner <olce> | ||||||||
| Component: | Individual Port(s) | Assignee: | Vladimir Druzenko <vvd> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | grahamperrin, vbox, vvd | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(vbox) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://reviews.freebsd.org/D40487 | ||||||||||
| Attachments: |
|
||||||||||
Maintainer feedback, please. (In reply to Graham Perrin from comment #1) Timeout? Also, do we need this:
.if ${ARCH} == i386
KMK_ARCH= freebsd.x86
PLIST_SUB+= I386=""
.else
KMK_ARCH= freebsd.${ARCH}
PLIST_SUB+= I386="@comment "
.endif
if there is ONLY_FOR_ARCHS= amd64 in the port?
Hi Vladimir, I think this can safely be removed in conjunction with the following two lines in 'pkg-plist': %%I386%%lib/virtualbox/VBoxREM32.so %%I386%%lib/virtualbox/VBoxREM64.so AFAIU, VirtualBox dropped 32-bit host support in 6.x. This additional change is cosmetic, whereas the initially proposed one enables building VirtualBox on an amd64 machine without 32-bit libraries installed. Both changes could be grouped. Regards. Created attachment 242382 [details]
Remove requirement for 32-bit libraries
Created attachment 242383 [details]
Remove remnants of i386 support
Patch removing the i386 logic (i386 not supported since VirtualBox 6.x).
(In reply to Olivier Certner from comment #5) Updated the previous patch with another patch readily applicable with 'git am' (and with removal of some now obsolete part I had originally missed). (In reply to Vladimir Druzenko from comment #3) See the second patch. Build succeeds with Poudriere. I'll deal with it after this PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265539 A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fd06fe3d7c9a9bc13ec7828f18d4e652aa102604 commit fd06fe3d7c9a9bc13ec7828f18d4e652aa102604 Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2023-06-12 16:05:20 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2023-06-12 16:05:20 +0000 emulators/virtualbox-ose: Remove unnecessary dependency on 32-bit compat for amd64 32-bit in-kernel support and lib32 libs are not necessary for VirtualBox 6.x, so just remove this requirement. Also the port support amd64 only - remove I386 from PLIST_SUB. PR: 266382 Tested by: Olivier Certner <olivier.freebsd@free.fr> Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D40487 emulators/virtualbox-ose/Makefile | 24 ------------------------ emulators/virtualbox-ose/pkg-plist | 2 -- 2 files changed, 26 deletions(-) Thanks! (And please mind adding a "Submitted by:" next time. ;-)) (In reply to Olivier Certner from comment #10) > Submitted by: (deprecated) > This has been deprecated with git; submitted patches should have the author set by using git commit --author with a full name and valid email. https://docs.freebsd.org/en/articles/committers-guide/#_include_appropriate_metadata_in_a_footer This? Yes, even better. Thanks. |
Created attachment 236518 [details] Remove 32-bit support checks 32-bit in-kernel support and lib32 libs are not necessary to build VirtualBox, so let's just remove this requirement. (Tested on a recent 13.1-STABLE and some 12.3-STABLE .) (Enabling option GUESTADDITIONS just downloads a pre-packaged ISO, so whether building guest additions require 32-bit support is irrelevant here. For the record, emulators/virtualbox-ose-additions doesn't check that such support is present.)