Bug 266430
| Summary: | net-im/profanity: Use upstream release archive and some fixes to Makefile | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||
| Component: | Individual Port(s) | Assignee: | Ashish SHUKLA <ashish> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | Flags: | ashish:
maintainer-feedback+
|
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 236656 [details]
Additional patch to ease use of python embed
This attached patch removes the diff hunk which got accidentally added when I regenerated the patch using `make makepatch' after REINPLACE_CMD. The REINPLACE_CMD makes sure the desired python library is used instead of the hardcoded one.
Could you please apply this patch on top of yours, or even better merge with yours, and commit it ?
Your patch looks good, and thanks for pointing out the REINPLACE_CMD change which I missed. Sorry about that. Could you please use the diff I submitted in comment #1, which brings the REINPLACE_CMD change while removing the useless python-embed diff which sneaked in due to my lack of attention ? Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=15b2c42e96fa6562ec63def52ae97ebd937276b7 commit 15b2c42e96fa6562ec63def52ae97ebd937276b7 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-09-25 17:48:31 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-09-25 22:46:47 +0000 net-im/profanity: Use upstream release archive and some other fixes - Use upstream release archive as recommended in USE_GITHUB section in Porters Handbook - Remove OpenSSL dependency - Add USE_LDCONFIG - Rearrange Makefile to follow Porters Handbook more closely - Fix Python detection (patch provided by maintainer) PR: 266430 Reviewed by: ashish (maintainer) net-im/profanity/Makefile | 21 ++++++++++----------- net-im/profanity/distinfo | 6 +++--- net-im/profanity/files/patch-configure.ac | 9 --------- 3 files changed, 13 insertions(+), 23 deletions(-) |
Created attachment 236579 [details] Patch for profanity Use upstream release archive as recommended in USE_GITHUB section in Porters Handbook Drop OpenSSL dependency (compiles without and I can't find any references in the code using grep) Add USE_LDCONFIG Remove REINPLACE_CMD as it doesn't match anything (reported by Poudriere) and Python gets detected anyway Rearrange Makefile to follow Porters Handbook more closely Compile tested on FreeBSD 13.1-STABLE #0 stable/13-n251817-0c4d13c521a (amd64) (make, make check-plist) Poudriere testport OK 12.3-RELEASE (amd64)