Bug 266593

Created attachment 236802 [details]
Update to 14.20.1

Security fix release 14.20.1

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266591 for vuxml.

portlint: ok. 1 expected warning.  See 263859.
testport: ok. {12,13}{i386,amd64}
uniitest: ok.

All:
gtest: [  PASSED  ] 135 tests.
gmake tooltest: Ran 6 tests in 0.002s


12i386:
jsttest: [04:43|% 100|+ 3282|-   3]: Done
=== release test-http2-methods ===
=== release test-http2-multiplex ===
=== release test-tls-no-sslv3 ===

12amd64:
[04:36|% 100|+ 3282|-   3]: Done
=== release test-http2-methods ===
=== release test-http2-multiplex ===
=== release test-tls-no-sslv3 ===
 
13i386:
=== release test-http2-methods ===
=== release test-http2-multiplex ===
jstest: [04:52|% 100|+ 3283|-   2]: Done

13amd64:
jstest: [04:46|% 100|+ 3282|-   3]: Done
=== release test-http2-methods ===
=== release test-http2-multiplex ===
=== release test-signal-handler ===



These two tests have already been reported upstream:
=== release test-http2-methods ===
=== release test-http2-multiplex ===
https://github.com/nodejs/node/issues/43080
https://github.com/nodejs/node/issues/43079

New failing tests
=== release test-tls-no-sslv3 ===
=== release test-signal-handler ===

I think these are non-issues.


=== release test-tls-no-sslv3 ===
12.3 sslv3 incompatibility with testing ciphers?

=== release test-tls-no-sslv3 ===
Path: parallel/test-tls-no-sslv3
CONNECTED(00000003)
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 7 bytes and written 58 bytes
Verification: OK
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
SSL-Session:
    Protocol  : SSLv3
    Cipher    : 0000
    Session-ID:
    Session-ID-ctx:
    Master-Key:
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    Start Time: 1664066079
    Timeout   : 7200 (sec)
    Verify return code: 0 (ok)
    Extended master secret: no
---
34371141632:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:/usr/src/crypto/openssl/ssl/record/rec_layer_s3.c:1544:SSL alert number 40
assert.js:394
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(/:wrong version number/.test(errors[0].message) ||
         /:version too low/.test(errors[0].message))

    at process.<anonymous> (/wrkdirs/usr/ports/www/node14/work/node-v14.20.1/test/parallel/test-tls-no-sslv3.js:46:5)
    at process.emit (events.js:412:35) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}
Command: out/Release/node /wrkdirs/usr/ports/www/node14/work/node-v14.20.1/test/parallel/test-tls-no-sslv3.js



Possible change between 13.0 and 13.1 amd64 related to this test.  12 and 13i386 are returning SIGILL vs 13amd64 is SIGBUS.

=== release test-signal-handler ===                                                                                                                                      
Path: abort/test-signal-handler                                                                                                                                          
assert.js:394                                                                                                                                                            
    throw err;                                                                                                                                                           
    ^               
                                                                                                                                                                         
AssertionError [ERR_ASSERTION]: child.signal = SIGBUS                                                                                                                    
    at Object.<anonymous> (/wrkdirs/usr/ports/www/node14/work/node-v14.20.1/test/abort/test-signal-handler.js:22:3)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)                                                                                            
    at Module.load (internal/modules/cjs/loader.js:950:32)                                                                                                               
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12)
    at internal/main/run_main_module.js:17:47 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}
Command: out/Release/node /wrkdirs/usr/ports/www/node14/work/node-v14.20.1/test/abort/test-signal-handler.js