Bug 26666

Summary: New port: pam_ssh (moved out from base)
Product: Base System Reporter: ajk <ajk>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.2-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.shar none

Description ajk 2001-04-18 06:50:00 UTC 
This PAM module provides single sign-on behavior for UNIX using
SSH.  Users are authenticated by decrypting their SSH private keys
with the password provided (probably to XDM).  In the PAM session
phase, an ssh-agent process is started and keys are added.

Please remove pam_ssh from the base.  As a port, it can more easily
be made to work with all versions of SSH on many platforms as a
standalone product.  (I realize it's too late for 4.3-RELEASE.)

How-To-Repeat: 
N/A
Comment 1 Will Andrews freebsd_committer freebsd_triage 2001-04-18 07:06:05 UTC 
State Changed
From-To: open->analyzed

Doesn't build on 4.3-RC: 

cc -pipe -fpic -DPIC -O -pipe  -Wall -c rijndael.c -o rijndael.So 
cc -pipe -fpic -DPIC -O -pipe  -Wall -c xmalloc.c -o xmalloc.So 
building shared library pam_ssh.so 
/usr/libexec/elf/ld: cannot find -lgcc_pic 
*** Error code 1 

Stop in /net/puck/will/ports/security/pam_ssh/work/pam_ssh-1.5. 
*** Error code 1 

Removing -lgcc_pic fixes it.  What shall we do here?
Comment 2 Will Andrews 2001-04-18 16:58:56 UTC 
David,

Am I right that revs 1.87 and 1.61.2.12 of src/sys/sys/param.h denote
the removal of -lgcc_pic?  I need an ${OSVERSION} check on this to regex
out the -lgcc_pic for newer systems.

See: http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/param.h

Andy,

It may be easier to simply use a regex in the port Makefile to adjust
settings, at least until you can make a similar adjustment in the
pam_ssh Makefile.  I think you'd want something similar to this:

OSVERSION!=	/sbin/sysctl -n kern.osreldate
.if (${OSVERSION} <= 420001)
LDADD+=	-lgcc_pic
.endif

You could wrap this with an .if (${OSNAME} == "FreeBSD")  if you are so
inclined to make it portable among BSD (with a similar definition of
course :-).

----- Forwarded message from "Andrew J. Korty" <ajk@iu.edu> -----

Date: Wed, 18 Apr 2001 10:39:37 -0500 (EST)
From: "Andrew J. Korty" <ajk@iu.edu>
To: <will@FreeBSD.org>
Cc: <freebsd-bugs@FreeBSD.org>
Subject: Re: bin/26666: New port: pam_ssh (moved out from base)

On Tue, 17 Apr 2001 will@FreeBSD.org wrote:

> State-Changed-Why:
> Doesn't build on 4.3-RC:
>
> cc -pipe -fpic -DPIC -O -pipe  -Wall -c rijndael.c -o rijndael.So
> cc -pipe -fpic -DPIC -O -pipe  -Wall -c xmalloc.c -o xmalloc.So
> building shared library pam_ssh.so
> /usr/libexec/elf/ld: cannot find -lgcc_pic
> *** Error code 1
>
> Stop in /net/puck/will/ports/security/pam_ssh/work/pam_ssh-1.5.
> *** Error code 1
>
> Removing -lgcc_pic fixes it.  What shall we do here?

I'm not sure why I was using -lgcc_pic before, but it doesn't appear
to be necessary under 4.2-RELEASE.  I've removed it from the Makefile
and moved the tag for 1.5, but I can't log in to SourceForge to
change replace the file.  I'll try later.

If you want, just make a patch to remove it.

-- 
Andrew J. Korty, Principal Security Engineer, GCIA
Office of the Vice President for Information Technology
Indiana University

----- End forwarded message -----

-- 
wca
Comment 3 David E. O'Brien freebsd_committer freebsd_triage 2001-04-18 19:03:57 UTC 
On Wed, Apr 18, 2001 at 10:58:56AM -0500, Will Andrews wrote:
> Am I right that revs 1.87 and 1.61.2.12 of src/sys/sys/param.h denote
> the removal of -lgcc_pic?

Yes.  [for the ELF case]

-- 
-- David  (obrien@FreeBSD.org)
Comment 4 Will Andrews freebsd_committer freebsd_triage 2001-05-05 20:22:27 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks.