Bug 266726

Summary: security/easy-rsa: executing sed with non-posix "\s" regex
Product: Ports & Packages Reporter: topical <topical>
Component: Individual Port(s)Assignee: Matthias Andree <mandree>
Status: Closed FIXED    
Severity: Affects Some People Flags: mandree: maintainer-feedback+
mandree: merge-quarterly+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://github.com/OpenVPN/easy-rsa/issues/714
Attachments:
Description Flags
Fix sed usage none

Description topical 2022-09-30 14:26:26 UTC
Created attachment 236971 [details]
Fix sed usage

At several instances, "\s" is passed to sed. This regex is non-posix and not supported by FreeBSD's sed. Since FreeBSD 13 you even get a warning message on execution.

Replacing "\s" with "[[:space:]]" fixes that (patch attached).
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2022-10-02 09:03:38 UTC
Forwarded upstream in a new issue https://github.com/OpenVPN/easy-rsa/issues/714
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-02 09:08:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5d062d5c18a1de48b8c30bf69929e1e3cb37679f

commit 5d062d5c18a1de48b8c30bf69929e1e3cb37679f
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2022-10-02 09:07:03 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-10-02 09:08:17 +0000

    security/easy-rsa: sed \s -> [[:space:]]

    Fix https://github.com/OpenVPN/easy-rsa/issues/714

    Patch suggested (needed to be integrated) and
    Reported by:    topical@gmx.net
    PR:             266726
    MFH:            2022Q4

 security/easy-rsa/Makefile            |  4 +---
 security/easy-rsa/files/patch-easyrsa | 26 ++++++++++++++++++++++----
 2 files changed, 23 insertions(+), 7 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-02 09:09:32 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=55ea846ac6a5a99865b07472505789b9d8835fc3

commit 55ea846ac6a5a99865b07472505789b9d8835fc3
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2022-10-02 09:07:03 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-10-02 09:08:40 +0000

    security/easy-rsa: sed \s -> [[:space:]]

    Fix https://github.com/OpenVPN/easy-rsa/issues/714

    Patch suggested (needed to be integrated) and
    Reported by:    topical@gmx.net
    PR:             266726
    MFH:            2022Q4

    (cherry picked from commit 5d062d5c18a1de48b8c30bf69929e1e3cb37679f)

 security/easy-rsa/Makefile            |  4 +---
 security/easy-rsa/files/patch-easyrsa | 26 ++++++++++++++++++++++----
 2 files changed, 23 insertions(+), 7 deletions(-)
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2022-10-02 09:09:38 UTC
fixed in 3.1.0_3, thanks!