Bug 266729

Summary: security/john: fix build on armv7
Product: Ports & Packages Reporter: Robert Clausecker <fuz>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Only Me CC: danfe
Priority: --- Flags: bugzilla: maintainer-feedback? (danfe)
Version: Latest   
Hardware: arm   
OS: Any   
URL: https://github.com/openwall/john/commit/c9825e688d1fb9fdd8942ceb0a6b4457b0f9f9b4
Attachments:
Description Flags
security/john: fix build on armv7 fuz: maintainer-approval? (danfe)

Description Robert Clausecker freebsd_committer freebsd_triage 2022-09-30 16:32:25 UTC
Created attachment 236973 [details]
security/john: fix build on armv7

This change applies an upstream patch, fixing AArch32 NEON intrinsics in the port.

Tested on armv7 FreeBSD 13.1.
Please MFH if committed after 2022Q4 is branched off.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-09-30 18:12:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5c648bf25f56ca85cf4bbc21cc2ec3fb7ffbdc77

commit 5c648bf25f56ca85cf4bbc21cc2ec3fb7ffbdc77
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2022-09-30 18:11:46 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2022-09-30 18:11:46 +0000

    security/john: attempt to fix the build on armv7

    This is from upstream commit c9825e6 which improves
    ARM pseudo-intrinsics portability.

    PR:             266729
    Submitted by:   Robert Clausecker

 security/john/files/patch-pseudo__intrinsics.h (new) | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-09-30 18:19:00 UTC
Committed, thanks!  Since it was just one file, I've opted to standard path-based patch name rather than embedding commit hash in it (but mentioned in the log).
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-09-30 19:14:51 UTC
AArch64 still fails, will investigate that one next.