Summary: | graphics/lensfun: build fails | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Ivan Rozhuk <rozhuk.im> | ||||
Component: | Individual Port(s) | Assignee: | Alexey Dokuchaev <danfe> | ||||
Status: | Open --- | ||||||
Severity: | Affects Some People | CC: | rozhuk.im | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(danfe) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Ivan Rozhuk
2022-10-03 19:26:28 UTC
Interesting, I've never encountered this error. Could it be caused by ccache, these lines: -- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES) -- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES) -- Could NOT find OpenMP (missing: OpenMP_C_FOUND OpenMP_CXX_FOUND) -- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES) -- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES) -- Could NOT find OpenMP (missing: OpenMP_C_FOUND OpenMP_CXX_FOUND) or combination of both? Is is not ccache, I prefer to have minimal deps and OpenMP could be not installed in my system. (In reply to Ivan Rozhuk from comment #2) > I[t] is not ccache Good to have it ruled out. > I prefer to have minimal dep[endencies] and OpenMP could be not installed > in my system. Understood, albeit OpenMP should be natively supported by recent Clang and thus not pull any external dependency. But okay, can you comment out all OpenMP-related lines in the tests/CMakeLists.txt and see if it helps? Something like this: post-patch: @${REINPLACE_CMD} -e '/OpenMP/d' ${WRKSRC}/tests/CMakeLists.txt ... Found an old upstream issue which looks related: https://github.com/lensfun/lensfun/issues/705, quote: > Second, if OpenMP is not found, then ${OpenMP_CXX_FLAGS} will be the string > "NOTFOUND" which leads to compile errors. Same issue with audio/fluidsynth. May be add some check for WITHOUT_OPENMP= in /etc/make.conf like done for GSSAPI? (In reply to Ivan Rozhuk from comment #5) > Same issue with audio/fluidsynth. I still don't know how to reproduce it (without hacking system files to trigger the check) but for this particular port, you can disable OpenMP explicitly via "enable-openmp" option. > Maybe add some check for WITHOUT_OPENMP= in /etc/make.conf like done for GSSAPI? Sorry, I don't understand this phrase. Meanwhile, you haven't answered my question in comment #3 whether patching OpenMP in tests/CMakeLists.txt helps. I already forgot the details, but seem to vaguely recall OpenMP might not actually be used for those tests. I wonder if ports b13bdddc8045 would change anything for you; if not, the question whether patching out OpenMP from `tests/CMakeLists.txt' still stands. 1. No, https://cgit.freebsd.org/ports/commit/?id=b13bdddc8045 does not help. 2. Yes, change from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266801#c3 work for me. Created attachment 241920 [details]
patch
Comment on attachment 241920 [details]
patch
I've grepped the tests' source code and some of them actually use OpenMP (#ifdef _OPENMP), thus we should not blindly disable it. So we're back to square one I'm afraid and still need to understand what's wrong with your system. Do you have /usr/include/omp.h file?
(In reply to Alexey Dokuchaev from comment #10) My system was build with: WITHOUT_OPENMP= in /etc/src.conf |