Bug 266867

Summary: audio/rosegarden: 22.06 available but fails to compile
Product: Ports & Packages Reporter: tuc03516
Component: Individual Port(s)Assignee: Adriaan de Groot <adridg>
Status: Closed Unable to Reproduce    
Severity: Affects Only Me CC: tuc03516
Priority: --- Flags: bugzilla: maintainer-feedback? (adridg)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://www.rosegardenmusic.com/getting/source/

Description tuc03516 2022-10-06 16:02:43 UTC 
Rosegarden 22.06 was released June 8th, 2022. attempting to update via source causes a failure I'm having trouble identifying. 

*** Failed target:  do-build
*** Failed command: (cd /usr/ports/audio/rosegarden/work/.build; if ! /usr/bin/env NINJA_STATUS="[%p %s/%t] " QT_SELECT=qt5 QMAKEMODULES="/usr/ports/audio/rosegarden/work/rosegarden-22.06/mkspecs/modules:/usr/local/lib/qt5/mkspecs/modules" XDG_DATA_HOME=/usr/ports/audio/rosegarden/work XDG_CONFIG_HOME=/usr/ports/audio/rosegarden/work XDG_CACHE_HOME=/usr/ports/audio/rosegarden/work/.cache HOME=/usr/ports/audio/rosegarden/work PATH=/usr/ports/audio/rosegarden/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin PKG_CONFIG_LIBDIR=/usr/ports/audio/rosegarden/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig NO_PIE=yes MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES DESTDIR=/usr/ports/audio/rosegarden/work/stage PREFIX=/usr/local LOCALBASE=/usr/local CC="cc" CFLAGS="-O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing " CPP="cpp" CPPFLAGS="-isystem /usr/local/include" LDFLAGS=" -fstack-protector-strong -L/usr/local/lib " LIBS="" CXX="c++" CXXFLAGS="-O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include " MANPREFIX="/usr/local" BSD_INSTALL_PROGRAM="install -s -m 555" BSD_INSTALL_LIB="install -s -m 0644" BSD_INSTALL_SCRIPT="install -m 555" BSD_INSTALL_DATA="install -m 0644" BSD_INSTALL_MAN="install -m 444" ninja -j10 -v all; then if [ -n "Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer." ] ; then echo "===> Compilation failed unexpectedly."; (echo "Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer.") | /usr/bin/fmt 75 79 ; fi; false; fi)
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/audio/rosegarden

*** Failed target:  stage
*** Failed command: cd /usr/ports/audio/rosegarden && make CONFIG_DONE_ROSEGARDEN=1 /usr/ports/audio/rosegarden/work/.stage_done.rosegarden._usr_local
*** Error code 1
Comment 1 tuc03516 2022-10-06 17:13:21 UTC 
There are two errors I'm running into. The first in compiling. Rosegarden successfully compiles with a modification to the source as follows: 
rosegarden-22.06/src/gui/general/ActionData.cpp line 743 needs changed to "QVariant bg(QBrush());" from "Variant bg(Brush(QT::cyan));" in order to compile.

Once compiled/installed rosegarden is asking for "snd-seq-midi" which is linux only by the looks of it and trying to add anything to the midi transport will crash the application.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-11-12 20:11:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f8bf7986df29195ba91d8117526f5402b8a73254

commit f8bf7986df29195ba91d8117526f5402b8a73254
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2022-11-12 20:03:54 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-11-12 20:10:02 +0000

    audio/rosegarden: update to 22.06 (latest)

    Needs one source-level patch to get it to compile, different
    from what was suggested in the PR.

    PR:             266867
    Reported by:    tuc03516@gmail.com

 audio/rosegarden/Makefile                                     |  7 ++-----
 audio/rosegarden/distinfo                                     |  6 +++---
 .../files/patch-src_gui_general_ActionData.cpp (new)          | 11 +++++++++++
 3 files changed, 16 insertions(+), 8 deletions(-)
Comment 3 Adriaan de Groot freebsd_committer freebsd_triage 2022-11-12 20:40:40 UTC 
Your proposed change also changed the color (dropping the cyan background) so I did something similar to fix the vexing-parse.

You will need to be much more explicit about the MIDI problem: I don't use Rosegarden myself, so you will need to spell out a specific scenario (click menu "MIDI", click button "Add" ...) for me in order to test.
Comment 4 tuc03516 2022-11-12 20:47:17 UTC 
I’m still digging in to the midi issue I think the issue lies with how I normally use the FreeBSD desktop through xrdp with the pulse audio module. By default it uses Alsa so it seems to be unable to find a card then crashes. I’ll try to see if I can get a good dump from it to post here.
Comment 5 Adriaan de Groot freebsd_committer freebsd_triage 2022-12-06 12:56:50 UTC 
The update seems ok and no other reports of MIDI problems.