Bug 266917

Summary: cad/yosys: Fails to use cad/abc since 0.22
Product: Ports & Packages Reporter: Emmanuel Vadot <manu>
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape, uddka, yuri
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update cad/abc to g20220920 none

Description Emmanuel Vadot freebsd_committer freebsd_triage 2022-10-09 13:47:52 UTC 
yosys now emit some abc script that uses fraig -x instead of ifraig (See https://github.com/YosysHQ/yosys/commit/114253cd54808d929022014928eff9cd5eb0f275).
Problem is our cad/abc doesn't support this command.
Simply try to compile any project using yosys/abc and you will have :
2.41.1.1. Executing ABC.
Running ABC command: "abc" -s -f <abc-temp-dir>/abc.script 2>&1
ABC: ABC command line: "source <abc-temp-dir>/abc.script".
ABC: 
ABC: + read_blif <abc-temp-dir>/input.blif 
ABC: + read_lut <abc-temp-dir>/lutdefs.txt 
ABC: + strash 
ABC: + &get -n 
ABC: + &fraig -x 
ABC: &fraig: unknown option x
ABC: ** cmd error: aborting 'source <abc-temp-dir>/abc.script'

A good example is devel/lattice-ice40-examples-hx1k/

I couldn't find if there is some other abc that people are using or if updating cad/abc to the latest tag will solve this.
Comment 1 Emmanuel Vadot freebsd_committer freebsd_triage 2022-10-09 13:55:13 UTC 
Ok so our cad/abc is really old, testing with the latest commit now.
Also it's happening since yosys 0.21 not 0.22.
Yuri, how do you test yosys update ? I can't see how it could have work with any projects ?
Comment 2 Emmanuel Vadot freebsd_committer freebsd_triage 2022-10-09 13:57:57 UTC 
Created attachment 237164 [details]
Update cad/abc to g20220920
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-09 15:49:03 UTC 
^Triage: reporter is committer, assign accordingly
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-09 19:02:30 UTC 
*** Bug 260806 has been marked as a duplicate of this bug. ***
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-10-09 19:03:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=edd93bd3bac5f41a28f585ee9e0f641f1acb03b2

commit edd93bd3bac5f41a28f585ee9e0f641f1acb03b2
Author:     Emmanuel Vadot <manu@freebsd.org>
AuthorDate: 2022-10-09 18:34:03 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-10-09 19:02:15 +0000

    cad/abc: Update g20200322 -> g20220920

    PR:             266917 260806
    Approved by:    uddka@student.kit.edu (maintainer's timeout; 9+ months on PR#260806)

 cad/abc/Makefile                   |  4 ++--
 cad/abc/distinfo                   |  6 +++---
 cad/abc/files/patch-CMakeLists.txt |  6 +++---
 cad/abc/files/patch-Makefile       | 12 ++++++------
 4 files changed, 14 insertions(+), 14 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-10-09 19:23:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6c8b418801d41822d49602546e2b75dbccfc45bb

commit 6c8b418801d41822d49602546e2b75dbccfc45bb
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-10-09 19:21:17 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-10-09 19:21:17 +0000

    cad/yosys: Add comment about failing tests

    PR:             266917

 cad/yosys/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-09 19:25:16 UTC 
> Yuri, how do you test yosys update ? I can't see how it could have work with any projects ?

It is tested with 'make test'.
I myself had a pending update of cad/abc that wasn't committed. I didn't realize that cad/yosys depended on it. My bad.

Now tests are mostly passing, with some failures that I just reported upstream.

Closing ...
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-10-11 09:05:39 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9828a78a9c341eb3e1675c2da47db6b7d45c77dc

commit 9828a78a9c341eb3e1675c2da47db6b7d45c77dc
Author:     Emmanuel Vadot <manu@freebsd.org>
AuthorDate: 2022-10-09 18:34:03 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-10-11 09:05:00 +0000

    cad/abc: Update g20200322 -> g20220920

    PR:             266917 260806
    Approved by:    uddka@student.kit.edu (maintainer's timeout; 9+ months on PR#260806)

    (cherry picked from commit edd93bd3bac5f41a28f585ee9e0f641f1acb03b2)

 cad/abc/Makefile                   |  4 ++--
 cad/abc/distinfo                   |  6 +++---
 cad/abc/files/patch-CMakeLists.txt |  6 +++---
 cad/abc/files/patch-Makefile       | 12 ++++++------
 4 files changed, 14 insertions(+), 14 deletions(-)