Bug 267062

Summary: graphics/webp: unbundle libsharpyuv
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: vvd, xxjack12xx
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (sunpoet)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v1 (apply via "git am") none

Description Jan Beich freebsd_committer freebsd_triage 2022-10-15 00:26:04 UTC 
Created attachment 237311 [details]
v1 (apply via "git am")

After ports 36a733d8a533 libavif has LIBSHARPYUV option to use sharpyuv from webp. Let's unbundle the library for such consumers using upstream changes.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2022-10-16 16:56:12 UTC 
See also https://github.com/AOMediaCodec/libavif/issues/1164#issuecomment-1279633271
Libraries with unstable ABI are non-issue for rolling distros like FreeBSD e.g., webp update can just bump PORTREVISION in consumers.
Comment 2 Jack 2022-10-17 06:23:02 UTC 
Not sure if this is related or not but now libavif fails to compile with the sharpyuv option enabled.

root@jack:/usr/ports/graphics/libavif # make
===>   libavif-0.11.0 depends on package: libyuv>=0.0.1774 - found
===>   libavif-0.11.0 depends on file: /usr/local/bin/cmake - found
===>   libavif-0.11.0 depends on executable: ninja - found
===>   libavif-0.11.0 depends on package: pkgconf>=1.3.0_1 - found
===>   libavif-0.11.0 depends on shared library: libpng.so - found (/usr/local/lib/libpng.so)
===>   libavif-0.11.0 depends on shared library: libaom.so - found (/usr/local/lib/libaom.so)
===>   libavif-0.11.0 depends on shared library: libdav1d.so - found (/usr/local/lib/libdav1d.so)
===>   libavif-0.11.0 depends on shared library: libgav1.so - found (/usr/local/lib/libgav1.so)
===>   libavif-0.11.0 depends on shared library: libsharpyuv.so - not found
===>  Installing for webp-1.2.4
===>  Checking if webp is already installed
===>   webp-1.2.4 is already installed
      You may wish to ``make deinstall'' and install this port again
      by ``make reinstall'' to upgrade it properly.
      If you really wish to overwrite the old port of webp
      without deleting it first, set the variable "FORCE_PKG_REGISTER"
      in your environment or the "make install" command line.
*** Error code 1
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2022-10-17 07:20:28 UTC 
(In reply to Jack from comment #2)
Related.
Attached patch will fix this issue.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-12-30 09:19:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=786b3ebb6793a6254904cee75621240dfceb6060

commit 786b3ebb6793a6254904cee75621240dfceb6060
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-12-30 08:55:14 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-12-30 09:06:31 +0000

    graphics/webp: Unbundle libsharpyuv

    - Bump PORTREVISION for package change

    PR:             267062
    Submitted by:   jbeich
    Obtained from:  https://github.com/webmproject/libwebp/commit/a3b68c195e27248e4401e727dbdb21ea1ef1258f
                    https://github.com/webmproject/libwebp/commit/7deee8103edf77bf68095253668f4818d09609e1
                    https://github.com/webmproject/libwebp/commit/04764b56a00417d9c3aa5105f3b62a4445ac1fe6
                    https://github.com/webmproject/libwebp/commit/e8f83de2867456a75b13aa1e876b22e2d1e1c077

 graphics/webp/Makefile                      |   1 +
 graphics/webp/files/patch-libsharpyuv (new) | 591 ++++++++++++++++++++++++++++
 graphics/webp/pkg-plist                     |   7 +
 3 files changed, 599 insertions(+)
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-12-30 09:28:16 UTC 
Committed. Thanks!