Bug 267075

Comment 1 Thomas Zander 2022-10-15 11:07:07 UTC

I'll start working on it next week-ish, but anyone is welcome to help :)

Building multimedia/gstreamer1-plugins-dts and multimedia/gstreamer1-plugins-resindvd fails if devel/libgudev is also installed. Both abort with the following error message:

sys/v4l2codecs/meson.build:38:2: ERROR: Unknown variable "gstcodecs_dep".

The build of both can be fixed by applying the following patch:

--- ./sys/v4l2codecs/meson.build.ORIG   2022-06-16 00:36:22.000000000 +0200
+++ ./sys/v4l2codecs/meson.build        2022-10-16 10:47:15.783027000 +0200
@@ -34,6 +34,7 @@
 endif
 
 
+if false
 if have_v4l2 and libgudev_dep.found()
   gstv4l2codecs = library('gstv4l2codecs',
     v4l2codecs_sources,
@@ -47,4 +48,5 @@
   )
   pkgconfig.generate(gstv4l2codecs, install_dir : plugins_pkgconfig_install_dir)
   plugins += [gstv4l2codecs]
+endif
 endif

However, I have no idea what this means for their runtime behavior.

-- Martin

There is a similar issue with graphics/gstreamer1-plugins-gl. It seems that in all three cases, the gstreamer allocators library is missing.

It should probably get installed with gstreamer1-plugins-gl, but for FreeBSD ports the file gst-libs/gst/allocators/meson.build is patched as follows:

--- ./gst-libs/gst/allocators/meson.build.orig  2022-06-16 00:36:22.000000000 +0200
+++ ./gst-libs/gst/allocators/meson.build       2022-10-16 10:56:00.106322000 +0200
@@ -1,3 +1,4 @@
+if get_option('allocators').enabled()
 gst_allocators_headers = files([
   'allocators.h',
   'allocators-prelude.h',
@@ -58,3 +59,4 @@
   sources : allocators_gen_sources)
 
 meson.override_dependency('gstreamer-allocators-1.0', allocators_dep)
+endif

And the pkg-plist for gstreamer1-plugins-gl does not mention any allocator files... it seems that a separate ports for this needs to be created and then added as a dependency to gstreamer1-plugins-{dts,resindvd,gl}

-- Martin

Forgot to add the link to bug #267100.

-- Martin

The three comments above should go to a separate report for gstreamer-1.20.3.

Sorry for the confusion.

-- Martin

Comment 6 commit-hook 2022-11-06 16:27:56 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2d51705c0462207f39a5277ab2d4c228d86a16c3

commit 2d51705c0462207f39a5277ab2d4c228d86a16c3
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2022-11-05 21:05:15 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2022-11-06 16:27:32 +0000

    Update gstreamer1 to upstream release 1.20.4

    PR:             267075

 multimedia/gstreamer1-editing-services/Makefile |  4 ++--
 multimedia/gstreamer1-editing-services/distinfo |  6 +++---
 multimedia/gstreamer1-libav/Makefile            |  2 +-
 multimedia/gstreamer1-libav/distinfo            |  6 +++---
 multimedia/gstreamer1-plugins-core/Makefile     |  2 +-
 multimedia/gstreamer1-plugins-dts/Makefile      |  2 +-
 multimedia/gstreamer1-plugins/Makefile          | 10 +++++-----
 multimedia/gstreamer1-plugins/distinfo          | 18 +++++++++---------
 multimedia/gstreamer1-rtsp-server/Makefile      |  4 ++--
 multimedia/gstreamer1-rtsp-server/distinfo      |  6 +++---
 multimedia/gstreamer1-vaapi/Makefile            |  2 +-
 multimedia/gstreamer1-vaapi/distinfo            |  6 +++---
 multimedia/gstreamer1/Makefile                  |  4 ++--
 multimedia/gstreamer1/distinfo                  |  6 +++---
 14 files changed, 39 insertions(+), 39 deletions(-)