Summary: | emulators/virtualbox-ose-additions*: code to support VirtualBox shared folders: SAVENAME-related build failures on CURRENT ≥ 1400068 | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Graham Perrin <grahamperrin> |
Component: | Individual Port(s) | Assignee: | Graham Perrin <grahamperrin> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | CC: | grahamperrin, kib, mjg, trombik1973, vbox |
Priority: | --- | Flags: | mjg:
maintainer-feedback?
mjg: merge-quarterly? |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any | ||
URL: | https://github.com/freebsd/freebsd-ports/blob/main/emulators/virtualbox-ose/files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vnops.c#L1413-L1420 | ||
See Also: |
https://reviews.freebsd.org/D36542 https://github.com/helloSystem/ISO/issues/141#issuecomment-1256958678 https://reviews.freebsd.org/D11602 https://reviews.freebsd.org/D37074 |
Description
Graham Perrin
![]() ![]() 💭 If the likelihood of a quick fix for this bug is low, then (a thought): a) add an option to build with support for shared folders b) for now, make the default to build _without_ this support – and maybe mention this in UPDATING. Please note, this is not to chase a quick fix. It's partly to recognise that: * a relatively large percentage of users of this port will treat the port itself as essential * a relatively small subset will treat shared folders as essential. <https://www.freshports.org/emulators/virtualbox-ose-additions/#config> Retrospective ============= <https://github.com/freebsd/freebsd-ports/blob/7f06d5b68d3929faa7a2a94f12585a9f4a45f159/emulators/virtualbox-ose/files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vnops.c#L1417-L1436> Context (2017-07-18): > emulators/virtualbox-ose-additions: Add support for VirtualBox SharedFolder > > This is an experimental implementation of VirtualBox SharedFolder subsystem > support for FreeBSD. > > The implementation is based on github.com/lwhsu/freebsd-vboxfs. > > It's tested and worked as expected. > > The locking mechanism may need enhancements. > > Reviewed by: jkim (vbox), mat (mentor) > Approved by: jkim (vbox), mat (mentor) > Sponsored by: Netzkommune GmbH > Differential Revision: https://reviews.freebsd.org/D11602 Re: comment #0 mjg@ kib@ please, any pointers on how this might be fixed? Thank you It should to the same thing zfs is doing: #if __FreeBSD_version < 1400068 cnp->cn_flags |= SAVENAME; #endif basically all uses of SAVENAME hidden behind the above mjg@: thank you. Anyone: I'd like to attempt a patch, but this type of thing is way beyond me (sorry) … Summary line begins: emulators/virtualbox-ose-additions* – to signify that this bug also affects emulators/virtualbox-ose-additions-legacy emulators/virtualbox-ose-additions-nox11 emulators/virtualbox-ose-additions-nox11-legacy … although (side note) I suspect that the FreshPorts 'Find bugs' feature at pages such as <https://www.freshports.org/emulators/virtualbox-ose-additions-legacy/> does not work with wildcards in this way. https://people.freebsd.org/~mjg/vbox-savename.diff I can't be arsed to go through hoops to submit it upstream. According to their policy it is fine to denote the patch as MIT licensed, which I do. (In reply to Mateusz Guzik from comment #6) 1. assigning to myself, I'll prepare a diff for the four ports and open a review in Phabricator 2. you are my favourite person. (In reply to Mateusz Guzik from comment #6) > https://people.freebsd.org/~mjg/vbox-savename.diff > > I can't be arsed to go through hoops to submit it upstream. According to > their policy it is fine to denote the patch as MIT licensed, which I do. Comparing what's above with what's below … Anyone, please: before I proceed to a diff for Phabricator, does <https://github.com/freebsd/freebsd-ports/compare/main...grahamperrin:freebsd-ports:bug-267079.diff> look about right? Have I got the wrong end of the stick, poking at those two files? Or the right end? Cheers Looks fine. (In reply to Mateusz Guzik from comment #9) Thanks, I'll progress this … probably tomorrow night. <https://reviews.freebsd.org/D37074> ready for review. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c35a710801728ab8ed3b2639a9a89f890f6acc29 commit c35a710801728ab8ed3b2639a9a89f890f6acc29 Author: Mateusz Guzik <mjg@FreeBSD.org> AuthorDate: 2022-12-19 21:30:08 +0000 Commit: Graham Perrin <grahamperrin@FreeBSD.org> CommitDate: 2022-12-19 21:30:08 +0000 emulators/virtualbox-ose: fix builds on CURRENT SAVENAME was retired by D36542 https://reviews.freebsd.org/D36542 Bug 267079 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267079 involves failures to build four ports, for VirtualBox guest additions, on FreeBSD-CURRENT: emulators/virtualbox-ose-additions emulators/virtualbox-ose-additions-legacy emulators/virtualbox-ose-additions-nox11 emulators/virtualbox-ose-additions-nox11-legacy Fix bug 267079 for CURRENT 1400068 and greater by hiding the use of SAVENAME in patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vnops.c for: emulators/virtualbox-ose emulators/virtualbox-ose-legacy PR: : 267079 Author: : mjg Approved by: : ports-committers (lwhsu), khng Differential revision: https://reviews.freebsd.org/D37074 .../files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vnops.c | 2 ++ .../files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vnops.c | 2 ++ 2 files changed, 4 insertions(+) |