Bug 267132
| Summary: | multimedia/gstreamer1-plugins-{dts,resindvd}: fails to build if devel/libgusb and multimedia/v4l_compat are installed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | russo | ||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | alt2600, cat99.spam, fernape, gebhart, george, imb, jjb-b, maksim.e.kozlov, osidorkin, peo, ptarmigan, rhurlin, riggs, rkoberman, vvd | ||||||
| Priority: | --- | Keywords: | regression | ||||||
| Version: | Latest | Flags: | riggs:
maintainer-feedback+
riggs: merge-quarterly- |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267100 | ||||||||
| Bug Depends on: | 267510 | ||||||||
| Bug Blocks: | 261585 | ||||||||
| Attachments: |
|
||||||||
|
Description
russo
2022-10-16 20:07:49 UTC
And for what it's worth, these are the packages I had before this mess: gstreamer1-1.16.2 < needs updating (index has 1.20.3) gstreamer1-libav-1.16.2 < needs updating (index has 1.20.3) gstreamer1-plugins-1.16.2_7 < needs updating (index has 1.20.3) gstreamer1-plugins-a52dec-1.16.2_2 < needs updating (index has 1.20.3) gstreamer1-plugins-bad-1.16.2_3 < needs updating (index has 1.20.3) gstreamer1-plugins-core-1.16 < needs updating (index has 1.20.3) gstreamer1-plugins-dts-1.16.2_2 < needs updating (index has 1.20.3) gstreamer1-plugins-dvdread-1.16.2_4 < needs updating (index has 1.20.3) gstreamer1-plugins-gl-1.16.2_4 < needs updating (index has 1.20.3) gstreamer1-plugins-good-1.16.2_2 < needs updating (index has 1.20.3) gstreamer1-plugins-mpg123-1.16.2_2 < needs updating (index has 1.20.3) gstreamer1-plugins-ogg-1.16.2_2 < needs updating (index has 1.20.3) gstreamer1-plugins-pango-1.16.2_2 < needs updating (index has 1.20.3) gstreamer1-plugins-png-1.16.2_2 < needs updating (index has 1.20.3) gstreamer1-plugins-resindvd-1.16.2_4 < needs updating (index has 1.20.3) gstreamer1-plugins-theora-1.16.2_2 < needs updating (index has 1.20.3) gstreamer1-plugins-ugly-1.16.2_2 < needs updating (index has 1.20.3) gstreamer1-plugins-vorbis-1.16.2_2 < needs updating (index has 1.20.3) After deleting them all with "pkg delete -f" and trying to reinstall each one at a time, only the following could be installed: gstreamer1-1.20.3 gstreamer1-libav-1.20.3 gstreamer1-plugins-1.20.3 gstreamer1-plugins-a52dec-1.20.3 gstreamer1-plugins-bad-1.20.3 gstreamer1-plugins-dvdread-1.20.3 gstreamer1-plugins-good-1.20.3 gstreamer1-plugins-mpg123-1.20.3 gstreamer1-plugins-ogg-1.20.3 gstreamer1-plugins-pango-1.20.3 gstreamer1-plugins-png-1.20.3 gstreamer1-plugins-theora-1.20.3 gstreamer1-plugins-ugly-1.20.3 gstreamer1-plugins-vorbis-1.20.3 As it turns out, multimedia/gstreamer1-plugins-resindvd also fails with the same error: Header "sys/types.h" has symbol "makedev" : YES sys/v4l2codecs/meson.build:38:2: ERROR: Unknown variable "gstcodecs_dep". A full log can be found at /usr/ports/multimedia/gstreamer1-plugins-resindvd/work/gst-plugins-bad-1.20.3/_build/meson-logs/meson-log.txt and graphics/gstreamer1-plugins-gl is failing as in bug 267100 Oh, and one last thing: the "full log" shows no useful information that isn't in the console output. But I'll attach it anyway. Created attachment 237382 [details]
Full meson-log.txt file
This is the meson-log.txt file produced during the build that fails
I can't find any graphics/gstreamer1-plugins-dts. Are you in HEAD? (In reply to Fernando Apesteguía from comment #4) Hi Fernando, It's multimedia/gstreamer1-plugins-dts. I can confirm, that this and several other plugins (for example -resindvd, -hls, -rtmp, ...) do not build any more on my CURRENT boxes (unclean environment). This is after a full delete of all old gstreamer1 ports, like described in UPDATING ... (In reply to Fernando Apesteguía from comment #4) It was a cut/paste error that someone else has already fixed. It's multimedia/gstreamer1-plugins-dts, not graphics. Same 13.1-RELEASE-p2. same problem on 12.3 Was able to build with the following patch:
--- a/multimedia/gstreamer1-plugins-dts/Makefile +++ b/multimedia/gstreamer1-plugins-dts/Makefile @@ -14,4 +14,4 @@ LIB_DEPENDS= libdca.so:multimedia/libdca .include "${MASTERDIR}/Makefile" -MESON_ARGS+= -Dgpl=enabled +MESON_ARGS+= -Dgpl=enabled -Dv4l2codecs=disabled -Dsvthevcenc=disabled
(disabled codecs have separate ports so they shouldn't be built here anyway)
Created attachment 237581 [details] New meson-log.txt Attached new log ending with: ERROR: Unknown variable "allocators_dep" resulting from the change proposed in comment #9. One problem fixed and another shows up. This looks like the same issue that broke gstreamer-plugins-gl and may have the same work-around. Try adding "-Dallocators=enabled" to the last line of the port Makefile (/user/ports/multimedia/gstreamer1-plugins-dts/Makefile). MESON_ARGS+= -Dgpl=enabled -Dallocators=enabled With the change from comment #11, I still get the same error (Unknown variable "allocators_dep"). Email on the freebsd-ports mailing list from monochrome@twcny.rr.com suggests the following change to /usr/ports/graphics/gstreamer1-plugins-gl/Makefile. Add MESON_ARGS+= -Dallocators=enabled to the end. With that change, I can now finish compiling gstreamer1. But it seems evident to me that all these changes are workarounds, not a proper bug fix -- and I don't know what the proper fix is. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=629aa01a594ed009dce58d3b2ad75b0967bcec48 commit 629aa01a594ed009dce58d3b2ad75b0967bcec48 Author: Thomas Zander <riggs@FreeBSD.org> AuthorDate: 2022-11-01 23:19:40 +0000 Commit: Thomas Zander <riggs@FreeBSD.org> CommitDate: 2022-11-01 23:24:41 +0000 multimedia/gstreamer1-plugins-dts: Fix build in dirty environments This should fix the build in the presence of devel/libgusb and multimedia/v4l_compat as per discussion in the bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267132 PR: 267132 Reported by: russo@bogodyn.org multimedia/gstreamer1-plugins-dts/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) After https://cgit.freebsd.org/ports/commit/?id=629aa01a594ed009dce58d3b2ad75b0967bcec48 and https://cgit.freebsd.org/ports/commit/?id=040e9e09916bc42675bb0d3aa94fee4787bb15c3 I can not reproduce this build problem even if libgusb, v4l_compat and libdrm are installed. We can reopen this bug if the problem still persists, in which case it could be caused by a different dependency. multimedia/gstreamer1-plugins-resindvd is still affected (tail of comment 1). Issue subsequently reported in bug 267510 ^Triage: Re-open pending resolution of that issue Also, do these changes need merging to quarterly, ie: are quarterly users also affected? Since this got reopened because of bug 267132, you might also take a quick look at comment 5: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267132#c5 where it is mentioned (by someone else) that several *other* packages also fail to build in the same way. (In reply to Kubilay Kocak from comment #17) No, the quarterly branch is still on 1.16. The 1.20 update was IMO way too risky to merge without stabilisation time on head. (In reply to russo from comment #18) Adding the -Dv4l2codecs=disabled -Dsvthevcenc=disabled everywhere is probably not the right way to fix this universally. I'll try to find where the detection logic in the meson build files is broken. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6ff8606f00d2d368d6dd2d3e7535d1c1525f59bf commit 6ff8606f00d2d368d6dd2d3e7535d1c1525f59bf Author: Thomas Zander <riggs@FreeBSD.org> AuthorDate: 2022-11-02 08:28:31 +0000 Commit: Thomas Zander <riggs@FreeBSD.org> CommitDate: 2022-11-02 21:50:38 +0000 multimedia/gstreamer1-*: Fix plugin building in dirty environments This should solve (fingers crossed) the meson autodetection problem for the remaining plugins from the "bad" set when building in dirty environments. PR: 267132, 267510 multimedia/gstreamer1-plugins-dts/Makefile | 2 +- multimedia/gstreamer1-plugins/Makefile.common | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) After the last commit, I can now compile all gstreamer1 ports cleanly. still broken on my dirty system Run-time dependency wildmidi found: NO (tried pkgconfig and cmake) Has header "wildmidi_lib.h" : YES Fetching value of define "LIBWILDMIDI_VER_MAJOR" : 0L Fetching value of define "LIBWILDMIDI_VER_MINOR" : 4L Library WildMidi found: YES ext/wildmidi/meson.build:25:2: ERROR: Unknown variable "gstbadaudio_dep". A full log can be found at /usr/ports/multimedia/gstreamer1-plugins-dts/work/gst-plugins-bad-1.20.3/_build/meson-logs/meson-log.txt ===> Script "configure" failed unexpectedly. Please report the problem to multimedia@FreeBSD.org [maintainer] and attach the "/usr/ports/multimedia/gstreamer1-plugins-dts/work/gst-plugins-bad-1.20.3/_build/meson-logs/meson-log.txt" including the output of the failure of your make command. Also, it might be a good idea to provide an overview of all packages installed on your system (e.g. a /usr/local/sbin/pkg-static info -g -Ea). *** Error code 1 Stop. make: stopped in /usr/ports/multimedia/gstreamer1-plugins-dts A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b86933a61506cae4610ade1572f4788473cc8277 commit b86933a61506cae4610ade1572f4788473cc8277 Author: Thomas Zander <riggs@FreeBSD.org> AuthorDate: 2022-11-03 21:06:02 +0000 Commit: Thomas Zander <riggs@FreeBSD.org> CommitDate: 2022-11-03 21:08:29 +0000 multimedia/gstreamer1-*: Fix build in the presence of wildmidi PR: 267132 multimedia/gstreamer1-plugins/Makefile.common | 1 + 1 file changed, 1 insertion(+) (In reply to commit-hook from comment #24) works now in my dirty dirty system. (In reply to alt2600 from comment #25) Cool, glad we could fix this one as well! Thanks for your report! |
