Bug 267268
| Summary: | sysutils/libudisks: Rework port | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||||
| Component: | Individual Port(s) | Assignee: | Daniel Engberg <diizzy> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | diizzy, eduardo, grahamperrin, pauamma | ||||||||
| Priority: | --- | Keywords: | needs-qa | ||||||||
| Version: | Latest | Flags: | pauamma:
maintainer-feedback+
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
I have a Poudriere build running but it'll take some time (5-6h or so) as it pulls in rust it and my box is slow. You can of course review the changes irregardless. Created attachment 237525 [details]
Patch for libudisks v2
Cosmetic change, make portlint happy
Created attachment 237530 [details]
Patch for libudisks v3
Fix dependencies and options for building udisksctl's manpage
Poudriere testport OK 12.3-RELEASE (amd64)
Not sure how if its worth making a separate option for manpage(s) but that's what pulls in gtk-doc and friends. It's going to take me some time to understand your changes, but I welcome the opportunity, if only because it may point out to parts of the PHB I misunderstood, and perhaps to ways to make them clearer. (In reply to Daniel Engberg from comment #4) I'm fine with adding MANPAGES as a default option (or a default if UDISKSCTL is built), assuming it only pulls in gtk-doc for building. (In reply to Pau Amma from comment #5) Noting here that when I was slogging through the PHB while working on the initial port 3 years ago, I got the impression that "If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file" (https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-master_sites-github) applied in whatever wording it had then. (The GitHub UI may have been misleading or confusing me.) So no clarification needed there. Comment on attachment 237530 [details]
Patch for libudisks v3
Patch looks good to me. Noting that since I'm still mentored as a doc committer and not a ports committer at all, it's probably faster for one to take care of the rest.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9e33b6856e0e9fe01cb064db9488e137fe4e7b40 commit 9e33b6856e0e9fe01cb064db9488e137fe4e7b40 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-10-30 19:52:48 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-10-30 20:05:13 +0000 sysutils/libudisks: Rework port - Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section) which also removes dependency of gtk-doc except when UDISKSCTL is enabled - Update comments in Makefile - Use framework helpers for DOCS - Rearrange Makefile to improve readability PR: 267268 Reviewed by: pauamma (maintainer) sysutils/libudisks/Makefile | 46 +++++++++++++++------------------ sysutils/libudisks/distinfo | 6 ++--- sysutils/libudisks/pkg-plist | 61 -------------------------------------------- 3 files changed, 24 insertions(+), 89 deletions(-) Committed, thanks |
Created attachment 237521 [details] Patch for libudisks - Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section) which also removes dependency of gtk-doc - Update comments in Makefile - Use framework helpers for DOCS - Rearrange Makefile to improve readability Compile tested on FreeBSD 13.1-STABLE