Bug 267309

Summary: net/kafka: Regression in non-Kraft mode after update to 3.3.1
Product: Ports & Packages Reporter: Boris Korzun <drtr0jan>
Component: Individual Port(s)Assignee: Ronald Klop <ronald>
Status: Closed FIXED    
Severity: Affects Only Me CC: ronald, timp87
Priority: --- Flags: bugzilla: maintainer-feedback? (timp87)
drtr0jan: maintainer-feedback?
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://reviews.freebsd.org/D37731
Attachments:
Description Flags
port patch timp87: maintainer-approval+

Description Boris Korzun 2022-10-24 12:41:25 UTC 
There's a regression after update to 3.3.1 in non-Kraft mode

The port always creates /var/db/kafka/kraft dir. But it brokes the Kafka environment.

=====
[2022-10-24 12:37:48,099] ERROR Exiting Kafka due to fatal exception during startup. (kafka.Kafka$) org.apache.kafka.common.KafkaException: Found directory /var/db/kafka/kraft, 'kraft' is not in the form of topic-partition or topic-partition.uniqueId-delete (if marked for deletion). Kafka's log directories (and children) should only contain Kafka topic data.
====
Comment 1 Pavel Timofeev 2022-11-02 15:38:12 UTC 
Created attachment 237821 [details]
port patch

So sorry about that.
Can you test this patch?
Comment 2 Boris Korzun 2022-11-03 09:42:28 UTC 
(In reply to Pavel Timofeev from comment #1)
Thx. The patch works successfully.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-12-18 19:26:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=93b244dc10ce303f458a8e73683c18033de44fc0

commit 93b244dc10ce303f458a8e73683c18033de44fc0
Author:     Pavel Timofeev <timp87@gmail.com>
AuthorDate: 2022-12-18 09:31:11 +0000
Commit:     Ronald Klop <ronald@FreeBSD.org>
CommitDate: 2022-12-18 19:21:55 +0000

    net/kafka: fix regression in non-Kraft mode after update to 3.3.1

    "There's a regression after update to 3.3.1 in non-Kraft mode
    The port always creates /var/db/kafka/kraft dir. But it brokes the Kafka environment."

    PR:     267309
    Approved by: rene
    Differential Revision: https://reviews.freebsd.org/D37731

 net/kafka/Makefile  | 18 +++++++++++-------
 net/kafka/pkg-plist |  2 +-
 2 files changed, 12 insertions(+), 8 deletions(-)
Comment 4 Ronald Klop freebsd_committer freebsd_triage 2022-12-18 19:27:36 UTC 
Committed. Thanks for your work!