Bug 267377

Summary: net/rsync: Fails to build with ICONV=OFF FLAGS=ON
Product: Ports & Packages Reporter: Jonathan Chen <jon>
Component: Individual Port(s)Assignee: Rodrigo Osorio <rodrigo>
Status: Closed Overcome By Events    
Severity: Affects Some People CC: kirill
Priority: --- Keywords: needs-qa
Version: LatestFlags: bugzilla: maintainer-feedback? (rodrigo)
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Jonathan Chen freebsd_committer freebsd_triage 2022-10-26 22:27:20 UTC 
Created attachment 237665 [details]
patch

cut and paste error in port Makefile prevents rsync from being built when ICONV is disabled and FLAGS is enabled in the port options

Trivial fix:

diff --git a/net/rsync/Makefile b/net/rsync/Makefile
index 785b0d061f5d..3266ef680a1e 100644
--- a/net/rsync/Makefile
+++ b/net/rsync/Makefile
@@ -76,7 +76,7 @@ ZLIB_BASE_CONFIGURE_ON=	--with-included-zlib=no
 
 .include <bsd.port.options.mk>
 
-.if make(makesum) || ${PORT_OPTIONS:MRENAMED} || ${PORT_OPTIONS:MICONV} || ${PORT_OPTIONS:MRENAMED}
+.if make(makesum) || ${PORT_OPTIONS:MRENAMED} || ${PORT_OPTIONS:MICONV} || ${PORT_OPTIONS:MFLAGS}
 DISTFILES+=	${PORTNAME}-patches-${DISTVERSION}${EXTRACT_SUFX}
 .endif
Comment 1 Rodrigo Osorio freebsd_committer freebsd_triage 2022-11-13 08:24:38 UTC 
Fixed by commit fdb4b123a50e2c7744537529d93d45d931b76012
Thanks for the report