Bug 267382

Summary: www/newsboat: Upgrade to 2.29
Product: Ports & Packages Reporter: Marko Turk <mt-bugs>
Component: Individual Port(s)Assignee: Nuno Teixeira <eduardo>
Status: Closed FIXED    
Severity: Affects Only Me CC: eduardo, mt-bugs
Priority: --- Keywords: needs-patch, needs-qa
Version: LatestFlags: mt-bugs: maintainer-feedback+
Hardware: Any   
OS: Any   
URL: https://github.com/newsboat/newsboat/blob/r2.29/CHANGELOG.md
Attachments:
Description Flags
patch
mt-bugs: maintainer-approval-
Makefile.crates use
mt-bugs: maintainer-approval-
patch mt-bugs: maintainer-approval+

Description Marko Turk 2022-10-27 06:40:35 UTC 
Created attachment 237672 [details]
patch

Hi,

patch to upgrade newsboat port to 2.29.

Changelog:
https://github.com/newsboat/newsboat/blob/master/CHANGELOG.md#229---2022-09-25

Regards
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-27 10:44:50 UTC 
Created attachment 237675 [details]
Makefile.crates use

Sugestion:

Use Makefile.crates for CARGO-CRATES list instead of including it in Makefile.
Result is a cleaner Makefile and easier future updates.

---
Mk/Uses/cargo.mk:
.sinclude "${MASTERDIR}/Makefile.crates"
---
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-27 11:04:33 UTC 
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/contrib/newsboat_reorganize.py
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
Comment 3 Marko Turk 2022-10-28 16:08:14 UTC 
Hi,

attaching new patch with both Makefiles.crates and with plist fix.

Thanks for the help.

Regards.
Comment 4 Marko Turk 2022-10-28 16:08:36 UTC 
Created attachment 237692 [details]
patch
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-10-28 17:07:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2eda7fb28684c4afeb732c7e7941ae5cf8bc8fd2

commit 2eda7fb28684c4afeb732c7e7941ae5cf8bc8fd2
Author:     Marko Turk <mt-bugs@markoturk.info>
AuthorDate: 2022-10-28 17:03:25 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-28 17:04:36 +0000

    www/newsboat: Update to 2.29

    ChangeLog: https://github.com/newsboat/newsboat/blob/r2.29/CHANGELOG.md

    PR:             267382

 www/newsboat/Makefile              |  99 +----------------
 www/newsboat/Makefile.crates (new) | 105 ++++++++++++++++++
 www/newsboat/distinfo              | 218 ++++++++++++++++++++-----------------
 www/newsboat/pkg-plist             |   1 +
 4 files changed, 230 insertions(+), 193 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-28 17:07:39 UTC 
Committed, thanks!