Bug 267432

Summary: x11-wm/herbstluftwm: update to 0.9.5
Product: Ports & Packages Reporter: Zsolt Udvari <uzsolt>
Component: Individual Port(s)Assignee: Nuno Teixeira <eduardo>
Status: Closed FIXED    
Severity: Affects Only Me CC: eduardo
Priority: --- Keywords: easy
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://herbstluftwm.org/news.html
Attachments:
Description Flags
patch
uzsolt: maintainer-approval+
0.9.5, without github uzsolt: maintainer-approval+

Description Zsolt Udvari freebsd_committer freebsd_triage 2022-10-30 11:53:06 UTC
Created attachment 237721 [details]
patch

Simple update to 0.9.5

From changelog:
* key binds for release events
* new format %{ } for easier attribute access in the sprintf command
* new setting show_frame_decorations
* new attributes: content_geometry, at_end, content_geometry, panels.geometry_fallback
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2022-10-30 12:17:23 UTC
Triage: 

* a deprecated keyword

* the severity that's normal for an update.
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-30 20:16:05 UTC
Sugestion:

Switch to MASTER_SITES since tarball is available at:
https://herbstluftwm.org/tarballs/herbstluftwm-0.9.5.tar.gz
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2022-10-30 20:46:30 UTC
Switched to github almost 2 years ago (https://cgit.freebsd.org/ports/commit/x11-wm/herbstluftwm/Makefile?id=33f66d15dcb6d1db582416c7b23dab15e8e60c0b and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252268 ).

What is the better choice and why? I think the github is safer than a "personal" webpage (low risk of downtime, minimal risk of bad package).
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-30 21:06:23 UTC
(In reply to Zsolt Udvari from comment #3)

It's always better to use a static tarball when available instead of an auto-generated one.
Security is verified by its checksum.

See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

An example of a static and dymamic tarball:

https://github.com/jordansissel/xdotool/releases

Cheers
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2022-10-31 07:44:13 UTC
Created attachment 237743 [details]
0.9.5, without github

Use herbstluftwm.org/tarballs master site.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-10-31 12:35:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cb5a97daebbb0deb987ec2f1781d7d35df8340c8

commit cb5a97daebbb0deb987ec2f1781d7d35df8340c8
Author:     Zsolt Udvari <uzsolt@uzsolt.hu>
AuthorDate: 2022-10-31 12:33:27 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-31 12:34:40 +0000

    x11-wm/herbstluftwm: Update to 0.9.5

     - Switch to MASTER_SITES

    ChangeLog:      https://herbstluftwm.org/news.html
    PR:             267432

 x11-wm/herbstluftwm/Makefile | 5 ++---
 x11-wm/herbstluftwm/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 6 deletions(-)
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-31 12:36:02 UTC
Committed, thanks!