Bug 267517

Summary:

graphics/gstreamer1-plugins-gl: re-enable WAYLAND after 1.20.3 update

Product:

Ports & Packages

Reporter:

Jan Beich <jbeich>

Component:

Individual Port(s)

Assignee:

freebsd-multimedia (Nobody) <multimedia>

Status:

Closed FIXED

Severity:

Affects Only Me

Keywords:

patch, regression

Priority:

---

Version:

Latest

Hardware:

Any

OS:

Any

Bug Depends on:

Bug Blocks:

261585

Attachments:

Description	Flags
v1 (apply via "git am")	none
minor style	none

Description Jan Beich freebsd_committer

2022-11-02 10:17:30 UTC

Created attachment 237810 [details]
v1 (apply via "git am")

Wayland support (enabled by bug 227509) is required to render natively without using Xwayland. For example, it can be tested nested under Xorg (inside a window, a la Xephyr or VirtualBox) using a compositor that doesn't need configuration.

$ pkg install cage clapper
$ : ${XDG_RUNTIME_DIR=/tmp}; export XDG_RUNTIME_DIR
$ GST_DEBUG=\*:2 cage env -u DISPLAY clapper foo.y4m
0:00:00.450250539 12345    0x88fc8c240 WARN                 basesrc gstbasesrc.c:3688:gst_base_src_start_complete:<source> pad not activated yet
0:00:00.452030581 12345    0x88fc8c240 WARN                 basesrc gstbasesrc.c:3688:gst_base_src_start_complete:<source> pad not activated yet
0:00:00.541881101 12345    0x83fbc4590 WARN    clapperglbaseimporter gstclapperglbaseimporter.c:194:retrieve_gl_context_on_main:<clappergluploader0> Unknown Gdk display!
0:00:00.544992801 12345    0x83fbc4590 WARN               glcontext gstglcontext.c:530:gst_gl_context_get_current_gl_context: Could not retrieve current context
0:00:00.545029738 12345    0x83fbc4590 ERROR   clapperglbaseimporter gstclapperglbaseimporter.c:256:retrieve_gl_context_on_main: Could not retrieve Gdk OpenGL context
0:00:00.546247078 12345    0x859f055e0 WARN             clappersink gstclappersink.c:733:gst_clapper_sink_set_caps:<clappersink0> error: No importer for given caps found
0:00:00.546641035 12345    0x88fc8c240 ERROR                Clapper gstclapper.c:1293:error_cb:<clapperplayer0> ERROR: from element /GstPlayBin:playbin/GstPlaySink:playsink/GstBin:vbin/GstClapperSink:clappersink0: No importer for given caps found
0:00:00.546655761 12345    0x88fc8c240 ERROR                Clapper gstclapper.c:1295:error_cb:<clapperplayer0> Additional debug info: ../lib/gst/plugin/gstclappersink.c(733): gst_clapper_sink_set_caps (): /GstPlayBin:playbin/GstPlaySink:playsink/GstBin:vbin/GstClapperSink:clappersink0
0:00:00.546684002 12345    0x88fc8c240 ERROR                Clapper gstclapper.c:1170:emit_error:<clapperplayer0> Error: Error from element /GstPlayBin:playbin/GstPlaySink:playsink/GstBin:vbin/GstClapperSink:clappersink0: Resource not found.
No importer for given caps found
../lib/gst/plugin/gstclappersink.c(733): gst_clapper_sink_set_caps (): /GstPlayBin:playbin/GstPlaySink:playsink/GstBin:vbin/GstClapperSink:clappersink0 (gst-clapper-error-quark, 0)
0:00:00.550263037 12345    0x83fbc4590 WARN    clapperglbaseimporter gstclapperglbaseimporter.c:194:retrieve_gl_context_on_main:<clappergluploader1> Unknown Gdk display!
0:00:00.550812089 12345    0x83fbc4590 WARN               glcontext gstglcontext.c:530:gst_gl_context_get_current_gl_context: Could not retrieve current context
0:00:00.550818723 12345    0x83fbc4590 ERROR   clapperglbaseimporter gstclapperglbaseimporter.c:256:retrieve_gl_context_on_main: Could not retrieve Gdk OpenGL context
0:00:00.551377127 12345    0x859f055e0 WARN             clappersink gstclappersink.c:733:gst_clapper_sink_set_caps:<clappersink0> error: No importer for given caps found
0:00:00.551404790 12345    0x859f055e0 WARN                GST_PADS gstpad.c:4351:gst_pad_peer_query:<vconv:src> could not send sticky events

(com.github.rafostar.Clapper:12345): Clapper-CRITICAL **: Error from element /GstPlayBin:playbin/GstPlaySink:playsink/GstBin:vbin/GstClapperSink:clappersink0: Resource not found.
No importer for given caps found
../lib/gst/plugin/gstclappersink.c(733): gst_clapper_sink_set_caps (): /GstPlayBin:playbin/GstPlaySink:playsink/GstBin:vbin/GstClapperSink:clappersink0
^C

Comment 1 Jan Beich freebsd_committer

2022-11-02 10:30:42 UTC

Created attachment 237811 [details]
minor style

Simplify concatenation in -Dgl_winsys via :ts make(1) modifier (a la mesa-{dri,devel}).
This patch is optional due to cosmetic impact according to poudriere:

-    gl_winsys         : x11,egl ,wayland
+    gl_winsys         : x11,egl,wayland

Comment 2 commit-hook freebsd_committer

2022-11-12 20:40:11 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef2d73ff45602712fd586efaa21a65abf2647342

commit ef2d73ff45602712fd586efaa21a65abf2647342
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-11-02 09:34:15 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-11-12 20:38:12 +0000

    graphics/gstreamer1-plugins-gl: re-enable WAYLAND after e3b732b4791c

    $ clapper foo.mp4
    (com.github.rafostar.Clapper:1234): Clapper-CRITICAL **: Error from element /GstPlayBin:playbin/GstPlaySink:playsink/GstBin:vbin/GstClapperSink:clappersink0: Resource not found.
    No importer for given caps found
    ../lib/gst/plugin/gstclappersink.c(733): gst_clapper_sink_set_caps (): /GstPlayBin:playbin/GstPlaySink:playsink/GstBin:vbin/GstClapperSink:clappersink0
    ^C

    PR:             267517

 graphics/gstreamer1-plugins-gl/Makefile | 6 ++----
 multimedia/clapper/Makefile             | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

Comment 3 commit-hook freebsd_committer

2022-11-12 20:40:12 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=67f5dc164af5a5020ead937eb5dace0dfaf7e5ef

commit 67f5dc164af5a5020ead937eb5dace0dfaf7e5ef
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-11-02 10:26:07 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-11-12 20:38:17 +0000

    graphics/gstreamer1-plugins-gl: simplify quoting via :ts modifier

    PR:             267517

 graphics/gstreamer1-plugins-gl/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)