Bug 267574

Summary: x11-wm/icewm invalid paths in xsession desktop files
Product: Ports & Packages Reporter: Ron Wills <ron>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape, portmaster
Priority: --- Flags: portmaster: maintainer-feedback+
fernape: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
update execution path(s) in the .desktop files portmaster: maintainer-approval+

Description Ron Wills 2022-11-05 15:35:45 UTC 
Within the xsession shared files:

/usr/local/share/xsessions/icewm.desktop
/usr/local/share/xsessions/icewm-session.desktop

The entries TryExec and Exec are set to /usr/bin/icewm and /usr/bin/icewm-session. They should be set to /usr/local/bin/icewm and /usr/local/bin/icewm-session accordingly.

This causes graphical login managers, like slim, to fail on login.
Comment 1 Chris Hutchinson 2022-11-07 19:04:04 UTC 
Created attachment 237923 [details]
update execution path(s) in the .desktop files

Please commit the attached git diff for x11-wm/icewm.
The patch changes the execution path(s) for the .desktop
files included with icewm source.

Thanks! :-)
Comment 2 Chris Hutchinson 2022-11-07 19:07:29 UTC 
(In reply to Ron Wills from comment #0)
I've modified the affected path(s) within the .desktop
files. You should be able to apply the patch attached
to this pr(1) to your local ports tree w/o any trouble.
Else wait until the patch is committed to the official
ports source.

Thanks for the report! :-)

--chris
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-07 19:16:02 UTC 
(In reply to Chris Hutchinson from comment #2)
Is quarterly affected?
Comment 4 Chris Hutchinson 2022-11-07 19:17:22 UTC 
(In reply to Fernando Apesteguía from comment #3)
Yes. I guess that calls for an MFC?

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-11-08 16:40:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cbcb71ff6481effc9074eb601ef43d543738f036

commit cbcb71ff6481effc9074eb601ef43d543738f036
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2022-11-07 19:11:31 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-11-08 16:36:27 +0000

    x11-wm/icewm: fix invalid paths in desktop files

    This caused graphical login managers, like slim, to fail on login.

    PR:             267574
    Reported by:    ron@digitalcombine.ca
    MFH:            2022Q4

 x11-wm/icewm/files/patch-lib_icewm-session.desktop (new) | 13 +++++++++++++
 x11-wm/icewm/files/patch-lib_icewm.desktop (new)         | 13 +++++++++++++
 2 files changed, 26 insertions(+)
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-08 16:41:44 UTC 
Committed and merged to 2022Q4,

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-11-08 16:41:48 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bed229375d7b70292f7e01787df23d25f5043233

commit bed229375d7b70292f7e01787df23d25f5043233
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2022-11-07 19:11:31 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-11-08 16:37:35 +0000

    x11-wm/icewm: fix invalid paths in desktop files

    This caused graphical login managers, like slim, to fail on login.

    PR:             267574
    Reported by:    ron@digitalcombine.ca
    MFH:            2022Q4

    (cherry picked from commit cbcb71ff6481effc9074eb601ef43d543738f036)

 x11-wm/icewm/files/patch-lib_icewm-session.desktop (new) | 13 +++++++++++++
 x11-wm/icewm/files/patch-lib_icewm.desktop (new)         | 13 +++++++++++++
 2 files changed, 26 insertions(+)