Bug 267599
| Summary: | www/restinio: Use upstream release archive | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||
| Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(yuri) |
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Thanks for the patch. This patch breaks the build when SAMPLES=ON. * fatal error: 'clara.hpp' file not found * also #include <asio.hpp> in installed files isn't satisfied Perhaps it is broken with RESTINIO_USE_BOOST_ASIO=shared - I am not sure what this does/supposed to do. But it works with RESTINIO_USE_BOOST_ASIO=none. (In reply to Yuri Victorovich from comment #1) Ahh... thanks, I'll have a look again at it. The idea (at least according to upstream) is to toggle between asio in boost and the external library. https://github.com/Stiffstream/restinio/blob/master/dev/CMakeLists.txt#L66 > The idea (at least according to upstream) is to toggle between asio in boost and the external library.
It looks like this doesn't really work. This project is also currently frozen, so I wouldn't expect them to fix this.
So I think that most reasonable way is to keep asio as it is now.
(In reply to Yuri Victorovich from comment #3) It does however users of restinio headers needs to define what library/code path they want to use. https://github.com/Stiffstream/restinio/blob/master/dev/restinio/asio_include.hpp#L11 Given the above I think we shouldn't define net/asio as a hard dependency opendht actually requires asio external (definition is missing in port) https://github.com/savoirfairelinux/opendht/blob/master/CMakeLists.txt#L80 and I would assume that any other potential user would do the same. Created attachment 237909 [details]
Patch for restinio
Fix SAMPLES option
Poudriere testport OK 12.3-RELEASE (amd64)
Committed, thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ecda0c704abcaa82a6a2a5ddb2c0c588afe05781 commit ecda0c704abcaa82a6a2a5ddb2c0c588afe05781 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-11-07 07:51:05 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2022-11-07 08:04:28 +0000 www/restinio: Use upstream release archive; Use Boost ASIO PR: 267599 www/restinio/Makefile | 34 ++++++++++++++++++++++------------ www/restinio/distinfo | 8 +++----- 2 files changed, 25 insertions(+), 17 deletions(-) |
Created attachment 237898 [details] Patch for restinio Use upstream release archive as recommended by Porters Handbook in USE_GITHUB section Use Boost Asio instead of standalone library to reduce amount of dependencies Compileand runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist, make test)