Bug 267618

Summary: net/opennx: Fix build on armv7
Product: Ports & Packages Reporter: Robert Clausecker <fuz>
Component: Individual Port(s)Assignee: Nuno Teixeira <eduardo>
Status: Closed FIXED    
Severity: Affects Many People CC: beyert, eduardo
Priority: --- Flags: bugzilla: maintainer-feedback? (beyert)
eduardo: merge-quarterly+
Version: Latest   
Hardware: arm   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240234
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261941
Attachments:
Description Flags
net/opennx: fix build on armv7 fuz: maintainer-approval? (beyert), koobs: maintainer-approval+

Description Robert Clausecker freebsd_committer freebsd_triage 2022-11-07 14:52:33 UTC 
Created attachment 237919 [details]
net/opennx: fix build on armv7

time_t is a long long on armv7, but OpenNX tries to store time stamps into
configuration storage that only eats long variables.  Cast to long and cross
fingers that nobody is going to use this port past 2036.

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Please MFH if possible.
Please see also bug #240234 and bug #261941.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-11-07 22:33:35 UTC 
Comment on attachment 237919 [details]
net/opennx: fix build on armv7

Approved by: portmgr (blanket: build fix)
MFH: 2022Q4
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-11-08 01:40:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dceaf660a726b36ac871827a7bbb70b89930f049

commit dceaf660a726b36ac871827a7bbb70b89930f049
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-08 01:35:21 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-11-08 01:39:37 +0000

    net/opennx: Fix build on armv7

    time_t is a long long on armv7, but OpenNX tries to store time stamps
    into configuration storage that only eats long variables.  Cast to long
    and cross fingers that nobody is going to use this port past 2036.

    PR:             267618
    Approved by:    portmgr (blanket: build fix)
    MFH:            2022Q4

 net/opennx/Makefile                        |  2 +-
 net/opennx/files/patch-opennxApp.cpp (new) | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-08 02:17:45 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0a6cda3b68cba83831c6e5f9fb434e8f892e7d2a

commit 0a6cda3b68cba83831c6e5f9fb434e8f892e7d2a
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-08 01:35:21 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-11-08 01:41:07 +0000

    net/opennx: Fix build on armv7

    time_t is a long long on armv7, but OpenNX tries to store time stamps
    into configuration storage that only eats long variables.  Cast to long
    and cross fingers that nobody is going to use this port past 2036.

    PR:             267618
    Approved by:    portmgr (blanket: build fix)
    MFH:            2022Q4

    (cherry picked from commit dceaf660a726b36ac871827a7bbb70b89930f049)

 net/opennx/Makefile                        |  2 +-
 net/opennx/files/patch-opennxApp.cpp (new) | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-11-08 02:18:47 UTC 
Committed, thanks!
Comment 5 Timothy Beyer 2022-11-09 01:07:00 UTC 
Maintainer approved, but also can someone apply my patch from February addressing the missing nxssh executable?
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2022-11-09 10:11:53 UTC 
@eduardo, could you please also have a look at bug #240234 and bug #261941?