Bug 267729

Summary: lang/see: fix build on armv7 arm64 riscv64
Product: Ports & Packages Reporter: Robert Clausecker <fuz>
Component: Individual Port(s)Assignee: Koichiro Iwao <meta>
Status: Closed FIXED    
Severity: Affects Only Me CC: meta, numisemis
Priority: --- Flags: numisemis: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
lang/see: fix build on armv7 arm64 riscv64 numisemis: maintainer-approval+

Description Robert Clausecker freebsd_committer freebsd_triage 2022-11-12 16:18:09 UTC
Created attachment 238034 [details]
lang/see: fix build on armv7 arm64 riscv64

Add missing architecture defines to dtoa_config.h

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Riscv64 should work fine, too, but I don't have my riscv box running right now.
Please MFH if possible.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-11-14 09:25:16 UTC
@Šimun Mikecin  Do you approve of the patch?
Comment 2 Šimun Mikecin 2022-11-14 09:52:13 UTC
(In reply to Robert Clausecker from comment #1)

Approved.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-12-05 06:26:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a61ecde1c605d0eea2f5daf7516eff383d6d508a

commit a61ecde1c605d0eea2f5daf7516eff383d6d508a
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-12 16:16:17 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-12-05 06:25:59 +0000

    lang/see: fix build on armv7 arm64 riscv64

    Add missing architecture cases to dtoa_config.h.

    PR:             267729

 lang/see/Makefile                                |  3 ---
 lang/see/files/patch-libsee_dtoa__config.h (new) | 12 ++++++++++++
 2 files changed, 12 insertions(+), 3 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-12-05 06:29:43 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8572b339f903636fff0c86fdd8cf15bf836e90db

commit 8572b339f903636fff0c86fdd8cf15bf836e90db
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-12 16:16:17 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-12-05 06:27:46 +0000

    lang/see: fix build on armv7 arm64 riscv64

    Add missing architecture cases to dtoa_config.h.

    PR:             267729
    (cherry picked from commit a61ecde1c605d0eea2f5daf7516eff383d6d508a)

 lang/see/Makefile                                |  3 ---
 lang/see/files/patch-libsee_dtoa__config.h (new) | 12 ++++++++++++
 2 files changed, 12 insertions(+), 3 deletions(-)
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2022-12-05 06:30:58 UTC
Committed, thanks!