Summary: | Request to create two new groups | ||
---|---|---|---|
Product: | Services | Reporter: | Lorenzo Salvadore <salvadore> |
Component: | Code Review | Assignee: | Phabric Admin <phabric-admin> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | CC: | carlavilla, debdrup, doceng, grahamperrin, lwhsu, pauamma |
Priority: | --- | ||
Version: | unspecified | ||
Hardware: | Any | ||
OS: | Any |
Description
Lorenzo Salvadore
2022-11-16 15:19:38 UTC
status-reviewers ================ Should this be a subproject of docs? <https://reviews.freebsd.org/project/subprojects/72/> The docs project is described as "People who are willing to review documentation changes (opt-in)". <https://secure.phabricator.com/book/phabricator/article/projects/#subprojects> I assume that watching a subproject should be not as noisy as watching the larger project. (In reply to Graham Perrin from comment #1) I did not know about the existence of subprojects. While it would be logical to make status-reviewers a subproject of docs, I would refrain from doing that because: - in the same link you gave us Graham, I read, after scrolling up a bit, that the "Subprojects and Milestones" feature is "only partially implemented"; - I do not see any advantage in having status-reviewers being a subproject of docs. If you see any, please share; - we do not have many groups in Phabricator and I think we have zero subgroups. And things seem to work well. Maybe subgroups are a feature for Phabricator instances that are more complex from our own, maybe it is also more useful for large business companies than for open source projects. So I would keep it simple at least for now and create both the new projects as normal projects. I guess we can always turn one or both of them into subprojects in the future if we want. Ping. Is there anything I can do to have this PR going forward? Thanks. (In reply to Lorenzo Salvadore from comment #0) How about have a single status-team (or other name you like) group, then adding official members as "members" and the reviewers as "watchers"? Thus when creating a new review doesn't need to add two groups and all the related people will be notified. (In reply to Li-Wen Hsu from comment #4) I like your idea, I think it is better than mine. It allows to distinguish members and reviewers but it is simpler than what I was proposing. In particular, it will make things easier for report submitters. Please name the new group just "status": it is now becoming the official name of the team, it is consitent with the new email address (status@) and with the already well known page https://www.freebsd.org/status/. Thanks. The group has been created: https://reviews.freebsd.org/project/profile/88/ I can't add watchers to this project, the permission model of phabricator model is very restrict and even administrator cannot touch many things via the web interface. Anyway, anyone can join a project as a watcher and will be notified when that group has been added as a group viewer. I hope this fulfill what you need. |