Bug 267862

Summary: games/openttd: wrong pkg-message when installing
Product: Ports & Packages Reporter: g.s
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Some People CC: danfe, grahamperrin
Priority: --- Keywords: needs-qa
Version: LatestFlags: grahamperrin: maintainer-feedback? (danfe)
Hardware: Any   
OS: Any   
URL: https://www.freshports.org/games/openttd/

Description g.s 2022-11-19 09:45:35 UTC
When installing openttd, it comes up with this message:

OpenTTD requires the original Windows version of "Transport Tycoon
    Deluxe" data files in order to function.  Copy the following files
    to /usr/local/share/openttd/data/ (or better, $HOME/.openttd/data/)
    directory:

        sample.cat
        trg1r.grf
        trgcr.grf
        trghr.grf
        trgir.grf
        trgtr.grf

However, I do neither have any of those files, nor those directories, yet it still seems to work fine.
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-11-19 14:44:37 UTC
(In reply to g.s from comment #0)
> However, I do neither have any of those files, nor those directories,
> yet it still seems to work fine.
OpenTTD can use original (proprietary) files listed in the pkg-message, or use free alternative graphics aka OpenGFX.  If original files are not found, OpenTTD will offer you to download OpenGFX files or exit the game.  Alternatively, you can install them from `games/opengfx' port or package, could it be the case?  Is there anything in your ~/.openttd/content_download directory?
Comment 2 g.s 2022-11-19 18:26:20 UTC
When you start it without an .openttd directory, it asks if you want to download the graphics. And if you confirm, you get a .local/share/openttd/content_download/baseset/4f474658-OpenGFX-7.1.tar. Moreover, the configs get stored in .config/openttd instead, it does not create an .openttd in my home.
Anyways, it does not require any files from the original version.
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-11-19 18:43:06 UTC
(In reply to g.s from comment #2)
> Anyways, it does not require any files from the original version.
I see.  When I've ported OpenTTD back in 2004, it was a hard requirement (free graphics did not exist at that time).  You're right, the text should be reworded, albeit not removed completely because there probably are folks who might still prefer the original artwork.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-02-07 05:52:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=beb2c1dcea42b2712734a36aad1ab5103ad3b7d5

commit beb2c1dcea42b2712734a36aad1ab5103ad3b7d5
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2023-02-07 05:49:54 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2023-02-07 05:49:54 +0000

    games/openttd: handle port's dependencies somewhat better (+)

    - Prevent Fluidsynth detection if it was explicitly disabled
    - Depend on SDL2 if it's being installed (but prefer SDL1 by
      default); this should only affect local (manual) builds
    - Original proprietary game data files had not been required
      for a while, rephrase the installation message accordingly

    PR:     267862

 games/openttd/Makefile                         | 11 ++++++++++-
 games/openttd/files/patch-CMakeLists.txt (new) | 22 ++++++++++++++++++++++
 games/openttd/files/pkg-message.in             | 18 +++++++++---------
 3 files changed, 41 insertions(+), 10 deletions(-)