Bug 267885

Summary:

devel/ruby-install: Add missing sudo dependency, update to 0.8.4, update to 0.8.5

Product:

Ports & Packages

Reporter:

Henry Phan <henry>

Component:

Individual Port(s)

Assignee:

Koichiro Iwao <meta>

Status:

Closed FIXED

Severity:

Affects Many People

CC:

henry, meta

Priority:

---

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Explicitly declare sudo as a runtime dependency of ruby-install	none
Bump ruby-install from 0.8.3 to 0.8.4	none
Bump ruby-install from 0.8.4 to 0.8.5	none

Description Henry Phan 2022-11-21 01:13:24 UTC

This bug report covers several issues, as it's been a while since I've had the time to contribute and happened to have the time to catch up on everything this afternoon. I've split the changes into three patches so it's easier to talk about them, and will attach them in follow-up comments, since I appear not to be able to add multiple attachments when filing a bug.

1. In my patch for #264168, I neglected to declare sudo as a runtime dependency of this port. (I installed FreeBSD on a new machine recently, and found that ruby-install doesn't work without sudo while transitioning to `doas`.) The attached 0001-add-missing-sudo-dependency.patch explicitly declares that dependency on sudo.

2. On 2022-08-01, ruby-install 0.8.4 was released. The attached 0002-bump-ruby-install-version-to-0.8.4.patch gets that version into the ports tree. It applies cleanly atop 0001-add-missing-sudo-dependency.patch.

3. On 2022-08-22, ruby-install 0.8.5 was released. The attached 0003-bump-ruby-install-version-to-0.8.5.patch gets _that_ version into the ports tree. It applies cleanly atop 0002-bump-ruby-install-version-to-0.8.4.patch.

I double-checked the functionality of each patch installing ruby-install with each patch (along with preceding patches, where relevant), and then verifying I could use the freshly-installed ruby-install to install Ruby 3.1.2.

If these changes are more-appropriately tracked with separate bugs, please let me know and I'll break them out.

Comment 1 Henry Phan 2022-11-21 01:14:01 UTC

Created attachment 238200 [details]
Explicitly declare sudo as a runtime dependency of ruby-install

Comment 2 Henry Phan 2022-11-21 01:14:38 UTC

Created attachment 238201 [details]
Bump ruby-install from 0.8.3 to 0.8.4

Comment 3 Henry Phan 2022-11-21 01:15:12 UTC

Created attachment 238202 [details]
Bump ruby-install from 0.8.4 to 0.8.5

Comment 4 commit-hook freebsd_committer

2022-11-24 04:01:46 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fcfeadc2a8dd0cfc7260896e146b02cd1bdeeb88

commit fcfeadc2a8dd0cfc7260896e146b02cd1bdeeb88
Author:     Henry Phan <henry@henryphan.com>
AuthorDate: 2022-11-21 07:18:04 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-11-24 01:58:02 +0000

    devel/ruby-install: Update to 0.8.5

    While here, add missing dependency on sudo.

    PR:             267885

 devel/ruby-install/Makefile | 4 ++--
 devel/ruby-install/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

Comment 5 commit-hook freebsd_committer

2022-11-24 04:08:48 UTC

A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3a7efbf99c579fa525c8d3123cf14a326f8521e3

commit 3a7efbf99c579fa525c8d3123cf14a326f8521e3
Author:     Henry Phan <henry@henryphan.com>
AuthorDate: 2022-11-21 07:18:04 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-11-24 04:03:34 +0000

    devel/ruby-install: Update to 0.8.5

    While here, add missing dependency on sudo.

    Merging into quarterly branch because it includes it is a leaf port and
    update includes only bugfixes. Also fixing dependency.

    PR:             267885

    (cherry picked from commit fcfeadc2a8dd0cfc7260896e146b02cd1bdeeb88)

 devel/ruby-install/Makefile | 4 ++--
 devel/ruby-install/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

Comment 6 Koichiro Iwao freebsd_committer

2022-11-24 04:11:59 UTC

Committed, thanks for the detailed follow-ups!
The changes are also applied to quarterly branch so pkg users will receive the fix soon.

Comment 7 Henry Phan 2022-11-27 21:58:07 UTC

Thanks, and happy Thanksgiving from the United States!