Bug 268085

Summary: [NEW PORT] x11/sfwbar flexible taskbar application for wayland compositors
Product: Ports & Packages Reporter: Tino Engel <tino.engel>
Component: Individual Port(s)Assignee: Gleb Popov <arrowd>
Status: Closed FIXED    
Severity: Affects Only Me CC: arrowd
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
The port as shar tar
none
The port as shar tar v2 none

Description Tino Engel 2022-11-30 17:45:35 UTC 
Created attachment 238457 [details]
The port as shar tar

SFWBar (S* Floating Window Bar) is a flexible taskbar application for wayland compositors, designed with a stacking layout in mind. 

https://github.com/LBCrion/sfwbar
Comment 1 Tino Engel 2022-12-02 09:45:38 UTC 
Created attachment 238486 [details]
The port as shar tar v2

Updated the archive after a review.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-12-02 10:05:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=097fb98c6a845d5f192e209efa1929d4cf802293

commit 097fb98c6a845d5f192e209efa1929d4cf802293
Author:     Tino Engel <tino.engel@mail.de>
AuthorDate: 2022-12-02 10:02:58 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2022-12-02 10:03:57 +0000

    x11/sfwbar: + Flexible taskbar application for wayland compositors

    PR:             268085

 x11/sfwbar/Makefile (new)             |  27 ++++++++
 x11/sfwbar/distinfo (new)             |   3 +
 x11/sfwbar/files/pkg-message.in (new) |  20 ++++++
 x11/sfwbar/pkg-descr (new)            |   7 ++
 x11/sfwbar/pkg-plist (new)            | 116 ++++++++++++++++++++++++++++++++++
 5 files changed, 173 insertions(+)
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2022-12-02 10:06:18 UTC 
Thank you for your contribution.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2022-12-02 10:41:51 UTC 
(In reply to commit-hook from comment #2)
> +++ b/x11/sfwbar/Makefile
> @@ -0,0 +1,27 @@
> +PORTNAME=	sfwbar
> +DISTVERSION=	v1.0_beta9

"v" should be moved to DISTVERSIONPREFIX, so it doesn't leak into PKGVERSION.

> +CATEGORIES=	x11

Add "wayland" per ports b2eed2d66478.

> +RUN_DEPENDS=	wayland-protocols>0:graphics/wayland-protocols

wayland-protocols is a bunch of *.xml files that are preprocessed into *.c files, so RUN_DEPENDS is only necessary when it leaks into consumers (e.g., via pkg-config like gtk40, mpv) or somehow used at runtime.

> +USES=		meson ninja pkgconfig gnome

- USES=meson already implies USES=ninja (this port doesn't use ninja directly)
- USES=gnome is not sorted alphabetically

> +USE_GNOME=	cairo gdkpixbuf2 glib20 gtk30

USE_GNOME=gtk30 already implies USE_GNOME=glib20. See _USE_GNOME_IMPL in Mk/Uses/gnome.mk

> +SUB_LIST=	DATADIR=${DATADIR}

SUB_LIST already contains DATADIR. See Mk/bsd.port.mk
Comment 5 Tino Engel 2022-12-02 10:49:08 UTC 
(In reply to Jan Beich from comment #4)

I will correct what has been remarked and will add another patch here if it is okay.
Please let me know if a new bug would be preferable.
Comment 6 Gleb Popov freebsd_committer freebsd_triage 2022-12-02 10:50:55 UTC 
(In reply to Jan Beich from comment #4)
Thanks for your input, I overlooked these things.
Comment 7 Jan Beich freebsd_committer freebsd_triage 2022-12-02 10:53:12 UTC 
(In reply to Jan Beich from comment #4)
> Add "wayland" per ports b2eed2d66478.

Rationale was in https://lists.freebsd.org/archives/dev-commits-ports-main/2022-July/028441.html

> the point of flagging a port in the wayland category is to make it
> easy to search for an application supporting wayland via: pkg search
> -g "wayland/*" for example.